Fix 1267 in remoteaccess panel

Add *.bak to .gitignore
Update README with specific Bugzilla links
2024-11-26 16:38:31 +00:00 · 2024-11-12 19:20:21 +00:00 · 2024-10-27 14:23:06 +00:00 · 2024-10-27 12:12:21 +00:00 · 2024-10-18 11:46:27 +01:00 · 2024-10-06 09:48:42 +01:00
29 changed files with 1473 additions and 555 deletions
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,4 @@
 *.log
 *spec-20*
 *.tar.xz
+*.bak
--- a/README.md
+++ b/README.md
@@ -13,7 +13,14 @@ SMEServer Koozali developed git repo for smeserver-manager smeserver
 <br />https://wiki.koozali.org/Server_Manager_2_Howto_incorporate_a_legacy_contrib

 ## Bugzilla
-Show list of outstanding bugs: [here](https://bugs.koozali.org/buglist.cgi?component=smeserver-manager&product=SME%20Server%2010.X&query_format=advanced&limit=0&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=CONFIRMED)
+Show list of outstanding bugs:
+[All](https://bugs.koozali.org/buglist.cgi?action=wrap&bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=NEEDINFO&bug_status=IN_PROGRESS&bug_status=RESOLVED&bug_status=VERIFIED&cf_package=smeserver-manager&classification=SME+Server&list_id=105756&order=changeddate+DESC%2Ccomponent%2Cpriority%2Cbug_severity&query_format=advanced)  
+[Confirmed](https://bugs.koozali.org/buglist.cgi?action=wrap&bug_status=CONFIRMED&cf_package=smeserver-manager&classification=SME+Server&order=changeddate+DESC%2Ccomponent%2Cpriority%2Cbug_severity&query_format=advanced)  
+[Unconfirmed](https://bugs.koozali.org/buglist.cgi?action=wrap&bug_status=UNCONFIRMED&cf_package=smeserver-manager&classification=SME+Server&order=changeddate+DESC%2Ccomponent%2Cpriority%2Cbug_severity&query_format=advanced)  
+[Need info](https://bugs.koozali.org/buglist.cgi?action=wrap&bug_status=NEEDINFO&cf_package=smeserver-manager&classification=SME+Server&order=changeddate+DESC%2Ccomponent%2Cpriority%2Cbug_severity&query_format=advanced)  
+[In progress](https://bugs.koozali.org/buglist.cgi?action=wrap&bug_status=IN_PROGRESS&cf_package=smeserver-manager&classification=SME+Server&order=changeddate+DESC%2Ccomponent%2Cpriority%2Cbug_severity&query_format=advanced)  
+[Resolved](https://bugs.koozali.org/buglist.cgi?action=wrap&bug_status=RESOLVED&cf_package=smeserver-manager&classification=SME+Server&order=changeddate+DESC%2Ccomponent%2Cpriority%2Cbug_severity&query_format=advanced)  
+[Verified](https://bugs.koozali.org/buglist.cgi?action=wrap&bug_status=VERIFIED&cf_package=smeserver-manager&classification=SME+Server&order=changeddate+DESC%2Ccomponent%2Cpriority%2Cbug_severity&query_format=advanced)

 ## Description

@@ -27,10 +34,10 @@ It is based on the perl Mojolicious package. Mojolicious is a real-time web fram
 smeserver-manager provides an intuitive and user-friendly web interface that allows administrators to manage various aspects of the server without needing deep technical knowledge or command-line skills.

 #### User and Group Management:
-Easily add, remove, and manage user accounts and groups. The interface simplifies creating email accounts, setting passwords, and configuring user permissions.
+It allows you to easily add, remove, and manage user accounts and groups. The interface simplifies creating email accounts, setting passwords, and configuring user permissions.

 #### Network Configuration:
-Configures network settings such as IP addresses, DNS, DHCP, and gateway settings. The interface also provides options for setting up VPNs, remote access, and firewall rules.
+You can configures network settings such as IP addresses, DNS, DHCP, and gateway settings. The interface also provides options for setting up VPNs, remote access, and firewall rules.

 #### File Sharing and Storage:
 Enables and manages file sharing services like Samba (for Windows file sharing) and NFS (for Unix/Linux file sharing). Administrators can easily create shared folders and manage permissions.
@@ -72,4 +79,4 @@ Dependencies: Relies on specific packages and configurations of SME Server, and

 ### Summary

-SMEserver-manager is a powerful tool that brings simplicity and efficiency to server management for small to medium-sized enterprises. By providing a centralized, web-based interface, it allows administrators to manage users, network settings, file sharing, email services, web hosting, and more, all from a single location.
+SMEserver-manager is a powerful tool that brings simplicity and efficiency to server management for small to medium-sized enterprises. By providing a centralized, web-based interface, it allows administrators to manage users, network settings, file sharing, email services, web hosting, and more, all from a single location.
--- a/2
+++ b/2
@@ -1,2 +0,0 @@
-* Sat Jul 27 2024 Brian Read <brianr@koozali.org> 11.0.0-11.sme
- Add in flag icon indication of locale [SME: 12706]
--- a/root/etc/e-smith/templates/etc/httpd/conf/httpd.conf/VirtualHosts/27SManagerProxyPass
+++ b/root/etc/e-smith/templates/etc/httpd/conf/httpd.conf/VirtualHosts/27SManagerProxyPass
@@ -40,5 +40,10 @@
            $OUT .= "        Require ip $localAccess $externalSSLAccess\n";
        }
        $OUT .= "    </Location>\n";
+        # prevent caching of manager files in browser
+        $OUT .= "   <LocationMatch \"/$place/.+\.(html|cgi)\$\">\n";
+        $OUT .= "                   Header set Cache-Control no-store\n";
+        $OUT .= "   </LocationMatch>\n";
+
    }
 }
--- a/root/etc/e-smith/templates/usr/share/smanager/themes/default/public/css/sme_core.css/50body
+++ b/root/etc/e-smith/templates/usr/share/smanager/themes/default/public/css/sme_core.css/50body
@@ -230,14 +230,6 @@ hr.sme-copyrightbar {
    font-size: 10px; 
 }

-#flag-icon {
-    font-size: 20px;
-    float: right;
-    margin-top: 0.67em;
-    margin-right: 1%;
-}
-
-
 /*These style definitions were found int he old css file (manager.css)
 but don't seem to ever be referenced in the code.  They're here
 for reference.
--- a/root/etc/e-smith/templates/usr/share/smanager/themes/default/public/css/sme_core.css/90contribs
+++ b/root/etc/e-smith/templates/usr/share/smanager/themes/default/public/css/sme_core.css/90contribs
@@ -67,5 +67,21 @@ hr.sme-copyrightbar {
 color: #8ebe43;
 background-color: #8ebe43;
    }
+      
+/* flag container no flag */
+#flag-container span {
+  font-size: 24px;
+}
+
+.fallback-box {
+  display: inline-block; /* Make it inline-block to fit around the content */
+  border: 2px solid gray; /* Change the border color as desired */
+  padding: 10px; /* Add some padding */
+  border-radius: 10px; /* Round the corners of the box */
+  font-size: 60px; /* Adjust size if needed */
+  margin-top: 10px; /* Add some margin */
+  text-align: center; /* Center text inside the box */
+}
+
 HERE
 }
--- a/root/etc/e-smith/templates/usr/share/smanager/themes/default/public/css/styles.css/50body
+++ b/root/etc/e-smith/templates/usr/share/smanager/themes/default/public/css/styles.css/50body
@@ -234,7 +234,7 @@ a.menu-title {
    width: 100%;
 }
 #h2e11 {
-    width: 70%;
+    width: 50%;
    float: left;
 }
 #h2e12 {
@@ -257,9 +257,9 @@ a.menu-title {
    width: 70%;
 }

-#h2e22,#h2e23 {
+#h2e22,#h2e23,#h2e12 {
    float: left;
-    width: 10%;
+    width: 14em;
    text-align: center;
 }

@@ -273,6 +273,7 @@ a.menu-title {
    left: 2px;
 }

+
 /*end*/
 EOF
 }
--- a/root/usr/share/smanager/lib/SrvMngr.pm
+++ b/root/usr/share/smanager/lib/SrvMngr.pm
@@ -25,8 +25,16 @@ use SrvMngr::Plugin::I18N;
 use SrvMngr::I18N;
 use SrvMngr::Model::Main;

+use SrvMngr::Plugin::WithoutCache;

-our $VERSION = '1.420';
+#this is overwrittrn with the "release" by the spec file - release can be "99.el8.sme"
+our $VERSION = ''; 
+#Extract the release value
+if ($VERSION =~ /^(\d+)/) {
+    $VERSION = $1;  # $1 contains the matched numeric digits
+} else {
+    $VERSION = '999' #No leading numeric digits found
+}
 $VERSION = eval $VERSION;

 use Exporter 'import';
@@ -210,6 +218,8 @@ sub setup_plugins {
    $self->plugin('TagHelpers');

    $self->plugin('RenderFile');
+    
+    $self->plugin('SrvMngr::Plugin::WithoutCache');

    # CSRF protection if production mode
 #    $self->plugin('Mojolicious::Plugin::CSRFDefender' => {
--- a/root/usr/share/smanager/lib/SrvMngr/Controller/Emailsettings.pm
+++ b/root/usr/share/smanager/lib/SrvMngr/Controller/Emailsettings.pm
@@ -12,6 +12,9 @@ use strict;
 use warnings;
 use Mojo::Base 'Mojolicious::Controller';

+use constant FALSE => 0;
+use constant TRUE  => 1;
+
 use Locale::gettext;
 use SrvMngr::I18N;

@@ -36,7 +39,7 @@ sub main {
    my $title = $c->l('mai_FORM_TITLE');

    $mai_datas{'trt'} = 'LIST';
-    $mai_datas{fetchmailmethod} = $cdb->get_prop('fetchmail', 'Method');
+    $mai_datas{fetchmailmethod} = $c->l($cdb->get_prop('fetchmail', 'Method'));

    $c->stash( title => $title, notif => '', mai_datas => \%mai_datas );
    $c->render(template => 'emailsettings');
@@ -56,13 +59,16 @@ sub do_display {
    my ($notif, $dest) = '';

    $mai_datas{'trt'} = $trt;
+	$cdb = esmith::ConfigDB->open || die "Couldn't open config db";

-        if ( $trt eq 'ACC' ) {
-	    $dest = 'emailaccess';
-	    $mai_datas{fetchmailmethod} = $cdb->get_prop('fetchmail', 'Method');
-        }
+	if ( $trt eq 'ACC' ) 
+    {
+		$dest = 'emailaccess';
+		$mai_datas{fetchmailmethod} = $cdb->get_prop('fetchmail', 'Method');
+    }

-        if ( $trt eq 'FIL' ) {
+    if ( $trt eq 'FIL' ) 
+    {
 	    $dest = 'emailfilter';
 	    $mai_datas{'virusstatus'} = $c->get_virus_status();
 	    $mai_datas{'spamstatus'} = $cdb->get_prop('spamassassin', 'status');
@@ -72,9 +78,10 @@ sub do_display {
 	    $mai_datas{spamsortspam} = $cdb->get_prop('spamassassin', 'SortSpam');
 	    $mai_datas{spamsubjecttag} = $cdb->get_prop('spamassassin', 'SubjectTag');
 	    $mai_datas{spamsubject} = $cdb->get_prop('spamassassin', 'Subject');
-        }
+    }

-        if ( $trt eq 'REC' ) {
+    if ( $trt eq 'REC' ) 
+    {
 	    $dest = 'emailreceive';
 	    $mai_datas{fetchmailmethod} = $cdb->get_prop('fetchmail', 'Method');
 	    $mai_datas{freqoffice} = $cdb->get_prop('fetchmail', 'FreqOffice');
@@ -86,9 +93,10 @@ sub do_display {
 	    $mai_datas{specifyheader} = get_secondary_mail_use_envelope();
 	    $mai_datas{secondarymailenvelope} = $cdb->get_prop('fetchmail', 'SecondaryMailEnvelope');

-	}
+    }

-        if ( $trt eq 'DEL' ) {
+    if ( $trt eq 'DEL' ) 
+    {
 	    $dest = 'emaildeliver';
 	    $mai_datas{emailunknownuser} = $cdb->get_value('EmailUnknownUser') || '"returntosender';
 	    $mai_datas{delegatemailserver} = $cdb->get_value('DelegateMailServer');
@@ -96,7 +104,7 @@ sub do_display {
 	    $mai_datas{smtpauthproxystatus} = $cdb->get_prop('smtp-auth-proxy', 'status') || 'disabled';
 	    $mai_datas{smtpauthproxyuserid} = $cdb->get_prop('smtp-auth-proxy', 'Userid') || '';
 	    $mai_datas{smtpauthproxypassword} = $cdb->get_prop('smtp-auth-proxy', 'Passwd') || '';
-	}
+    }


    $c->stash( title => $title, notif => $notif, mai_datas => \%mai_datas );
@@ -115,103 +123,113 @@ sub do_update {

    my %mai_datas = ();
    $mai_datas{trt} = $trt;
+	$cdb = esmith::ConfigDB->open || die "Couldn't open config db";

    my $title = $c->l('mai_FORM_TITLE');

    my ($dest, $res, $result) = '';

-    if ( $trt eq 'ACC' ) {
+    if ( $trt eq 'ACC' ) 
+    {
+     	$dest = 'emailaccess';
+			#	$mai_datas{xxx}	= $c->param('XXX');
+			
+			# controls
+			#	$res = xxxxxxx( $c );
+			#	$result .= $res unless $res eq 'OK';

-	$dest = 'emailaccess';
-#	$mai_datas{xxx}	= $c->param('XXX');
+			if ( ! $result ) 
+			{
+	    	$res = $c->change_settings_access();
+	    	$result .= $res unless $res eq 'OK';
+	    	if ( ! $result ) 
+				{ 
+					$result = $c->l('mai_SUCCESS'); 
+    		}
+			}
+   	}

-	# controls
-#	$res = xxxxxxx( $c );
-#	$result .= $res unless $res eq 'OK';
+    if ( $trt eq 'FIL' ) 
+			{
+			$dest = 'emailfilter';
+			#	$mai_datas{xxx}	= $c->param('XXX');
+			
+			# controls
+			#	$res = zzzzzz( $c );
+			#	$result .= $res unless $res eq 'OK';

-	if ( ! $result ) {
-	    $res = $c->change_settings_access();
-	    $result .= $res unless $res eq 'OK';
-	    if ( ! $result ) { 
-		$result = $c->l('mai_SUCCESS'); 
-	    }
-	}
-    }
+			if ( ! $result ) 
+			{
+	    	$res = $c->change_settings_filtering();
+	    	$result .= $res unless $res eq 'OK';
+	    	if ( ! $result ) 
+				{ 
+					$result = $c->l('mai_SUCCESS'); 
+    		}
+			}
+   	}

-    if ( $trt eq 'FIL' ) {
+    if ( $trt eq 'REC' ) 
+		{
+			$dest = 'emailreceive';
+			#	$mai_datas{xxx}	= $c->param('XXX');
+			
+			# controls
+			#	$res = yyyyyyyyy( $c );
+			#	$result .= $res unless $res eq 'OK';

-	$dest = 'emailfilter';
-#	$mai_datas{xxx}	= $c->param('XXX');
+			if ( ! $result ) 
+			{
+	    	$res = $c->change_settings_reception();
+	    	$result .= $res unless $res eq 'OK';
+	    	if ( ! $result ) 
+				{ 
+					$result = $c->l('mai_SUCCESS'); 
+    		}
+			}
+   	}

-	# controls
-#	$res = zzzzzz( $c );
-#	$result .= $res unless $res eq 'OK';
+    if ( $trt eq 'DEL' ) 
+		{
+			$dest = 'emaildeliver';
+			#	$mai_datas{xxx}	= $c->param('XXX');
+			
+			# controls
+			$res = $c->ip_number_or_blank( $c->param('DelegateMailServer') );
+			$result .= $res . ' DMS <br>' unless $res eq 'OK';

-	if ( ! $result ) {
-	    $res = $c->change_settings_filtering();
-	    $result .= $res unless $res eq 'OK';
-	    if ( ! $result ) { 
-		$result = $c->l('mai_SUCCESS'); 
-	    }
-	}
-    }
+			$res = $c->validate_smarthost( $c->param('SMTPSmartHost') );
+			$result .= $res . ' SH <br>' unless $res eq 'OK';

-    if ( $trt eq 'REC' ) {
+			$res = $c->nonblank_if_smtpauth( $c->param('SMTPSmartHost') );
+			$result .= $res . ' SH <br>' unless $res eq 'OK';

-	$dest = 'emailreceive';
-#	$mai_datas{xxx}	= $c->param('XXX');
+			$res = $c->nonblank_if_smtpauth( $c->param('SMTPAUTHPROXY_Userid') );
+			$result .= $res . ' USR <br>' unless $res eq 'OK';

-	# controls
-#	$res = yyyyyyyyy( $c );
-#	$result .= $res unless $res eq 'OK';
+			$res = $c->nonblank_if_smtpauth( $c->param('SMTPAUTHPROXY_Passwd') );
+			$result .= $res . ' PWD <br>' unless $res eq 'OK';

-	if ( ! $result ) {
-	    $res = $c->change_settings_reception();
-	    $result .= $res unless $res eq 'OK';
-	    if ( ! $result ) { 
-		$result = $c->l('mai_SUCCESS'); 
-	    }
-	}
-    }
-
-    if ( $trt eq 'DEL' ) {
-
-	$dest = 'emaildeliver';
-#	$mai_datas{xxx}	= $c->param('XXX');
-
-	# controls
-	$res = $c->ip_number_or_blank( $c->param('DelegateMailServer') );
-	$result .= $res . ' DMS <br>' unless $res eq 'OK';
-
-	$res = $c->validate_smarthost( $c->param('SMTPSmartHost') );
-	$result .= $res . ' SH <br>' unless $res eq 'OK';
-
-	$res = $c->nonblank_if_smtpauth( $c->param('SMTPSmartHost') );
-	$result .= $res . ' SH <br>' unless $res eq 'OK';
-
-	$res = $c->nonblank_if_smtpauth( $c->param('SMTPAUTHPROXY_Userid') );
-	$result .= $res . ' USR <br>' unless $res eq 'OK';
-
-	$res = $c->nonblank_if_smtpauth( $c->param('SMTPAUTHPROXY_Passwd') );
-	$result .= $res . ' PWD <br>' unless $res eq 'OK';
-
-	if ( ! $result ) {
-	    $res = $c->change_settings_delivery();
-	    $result .= $res unless $res eq 'OK';
-	    if ( ! $result ) { 
-		$result = $c->l('mai_SUCCESS');
-	    }
-	}
-    }
+			if ( ! $result ) 
+			{
+				$res = $c->change_settings_delivery();
+				$result .= $res unless $res eq 'OK';
+				if ( ! $result ) 
+				{ 
+					$result = $c->l('mai_SUCCESS');
+				}
+			}
+		}


    # common part

-    if ($res ne 'OK') {
-	$c->stash( error => $result );
-	$c->stash( title => $title, mai_datas => \%mai_datas );
-	return $c->render( $dest );
-    }
+    if ($res ne 'OK') 
+			{
+			$c->stash( error => $result );
+			$c->stash( title => $title, mai_datas => \%mai_datas );
+			return $c->render( $dest );
+    	}

    my $message = "emailsettings updates $trt DONE";
    $c->app->log->info($message);
@@ -221,7 +239,6 @@ sub do_update {

 };

-
 sub get_virus_status {

    my ($c, $localise) = @_;
@@ -249,10 +266,10 @@ sub localise_status {
 }


-sub get_prop {
+sub get_db_prop {

    my ($c, $item, $prop, $default) = @_;
-
+    
    return $cdb->get_prop($item, $prop) || $default;
 }

@@ -364,6 +381,48 @@ sub get_current_imap_access {
 }


+sub get_current_smtp_ssl_auth {
+    my ($c, $localise, $soru, $debug) = @_;
+    die "Error: \$soru must be either 's' or 'u':$soru.\n" unless $soru eq 's' || $soru eq 'u';
+	
+	$cdb = esmith::ConfigDB->open || die "Couldn't open config db";
+
+    # Initialize variables with default values
+    my $smtpStatus = 'none';
+    my $smtpAccess = 'none';
+    my $smtpAuth = 'disabled';  # assuming 'disabled' as a default
+    
+    
+
+    # Fetch SMTP settings based on the value of `$soru`
+    if ($soru eq "u") {
+        $smtpStatus = $cdb->get_prop('uqpsmtpd', 'status') || 'enabled'; # Fetch from uqpsmtpd
+        $smtpAccess = $cdb->get_prop('uqpsmtpd', 'access') || 'public';
+        $smtpAuth = 'enabled'; # Assuming authentication is enabled in this context
+    } else { 
+        $smtpStatus = $cdb->get_prop('sqpsmtpd', 'status') || 'enabled';  # Fetch from sqpsmtpd
+        $smtpAccess = $cdb->get_prop('sqpsmtpd', 'access') || 'public'; 
+        $smtpAuth = 'enabled';  # Assuming authentication is enabled in this context
+    }
+    
+    # Retrieve SMTP SSL authentication options
+    my $options = $c->get_smtp_ssl_auth_options();
+
+    
+    if ($soru eq "u" && $debug ) {
+		$c->stash('smtp'=>[$smtpStatus,$smtpAccess,$smtpAuth,$soru,$options->{$smtpAccess},$c->l($options->{$smtpAccess})]);
+#		die "Stop $soru in get_current_smtp_ssl_auth";
+	}
+    
+
+    # Return appropriate message based on SMTP settings
+    if ($smtpStatus eq 'enabled' && $smtpAuth eq 'enabled') {
+        return $localise ? $c->l($options->{$smtpAccess}) : $smtpAccess;
+    }
+    
+    return $localise ? $c->l($options->{disabled}) : 'disabled';
+}
+
 sub get_current_smtp_auth {

    my ($c, $localise) = @_;
@@ -371,16 +430,13 @@ sub get_current_smtp_auth {
    my $smtpStatus = $cdb->get_prop('qpsmtpd', 'status') || 'enabled';
    my $smtpAuth = $cdb->get_prop('qpsmtpd', 'Authentication') || 'enabled';

-    my $smtpsStatus = $cdb->get_prop('sqpsmtpd', 'status') || 'enabled';
-    my $smtpsAuth = $cdb->get_prop('sqpsmtpd', 'Authentication') || 'enabled';
-
    my $options = get_smtp_auth_options();

-    if ($smtpStatus eq 'enabled' && $smtpAuth eq 'enabled')
+    if ($smtpStatus eq 'enabled' && $smtpAuth eq 'disabled')
    {
        return $localise ? $c->l($options->{public}) : 'public';
    }
-    elsif ($smtpsStatus eq 'enabled' && $smtpsAuth eq 'enabled')
+    elsif ($smtpStatus eq 'enabled' && $smtpAuth eq 'enabled')
    {
        return $localise ? $c->l($options->{publicSSL}) : 'publicSSL';
    }
@@ -388,6 +444,8 @@ sub get_current_smtp_auth {
 }


+
+
 sub get_current_webmail_status {

  my ($c, $localise) = @_;
@@ -395,19 +453,16 @@ sub get_current_webmail_status {
  # determine status of webmail
  my $WebmailStatus = "disabled";

-  my $IMPStatus = $cdb->get_prop('imp', 'status') || 'disabled';
-
-  my $HordeStatus = $cdb->get_prop('horde', 'status') || 'disabled';
+  my $RoundcubeStatus = $cdb->get_prop('roundcube', 'status') || 'disabled';

  my $MysqlStatus = $cdb->get_prop('mariadb', 'status') || 'disabled';

-  my $PHPStatus = $cdb->get_prop('php', 'status') || 'disabled';
+  my $PHPStatus = $cdb->get_prop('php81-php-fpm', 'status') || 'disabled';

-  my $Networkaccess = $cdb->get_prop('horde','access') || 'disabled';
+  my $Networkaccess = $cdb->get_prop('roundcube','access') || 'disabled';

-  # all four components must be on for webmail to be working
-  if ( ( $IMPStatus eq "enabled" )
-       && ( $HordeStatus eq "enabled" )
+  # all 3 components must be on for webmail to be working
+  if ( ( $RoundcubeStatus eq "enabled" )
       && ( $MysqlStatus eq "enabled" )
       && ( $PHPStatus eq "enabled"   ) 
       && ( $Networkaccess eq "public"))
@@ -415,8 +470,7 @@ sub get_current_webmail_status {
      $WebmailStatus = "enabledSSL";
    }

-  elsif ( ( $IMPStatus eq "enabled" )
-       && ( $HordeStatus eq "enabled" )
+  elsif ( ( $RoundcubeStatus eq "enabled" )
       && ( $MysqlStatus eq "enabled" )
       && ( $PHPStatus eq "enabled"   )
       && ( $Networkaccess eq "private" ))
@@ -491,13 +545,58 @@ sub get_imap_options {
 }


+sub get_smtp_auth_opt {
+
+    my $c = shift;
+
+    return [[ $c->l('mai_SECURE_SMTP') => 'publicSSL'],
+	    [ $c->l('Only allow insecure access') => 'public'],
+	    [ $c->l('DISABLED') => 'disabled']
+	    ];
+}
+
 sub get_smtp_auth_options {
    
    my $c = shift;

-    my %options = ( disabled => 'DISABLED', publicSSL  => 'mai_SECURE_SMTP', public => 'mai_INSECURE_SMTP');
+    my %options = ( publicSSL  => 'mai_SECURE_SMTP', public => 'Only allow insecure access',disabled => 'DISABLED');

-    \%options;
+    return \%options;
+}
+
+
+sub get_smtp_ssl_auth_options {
+    
+    my $c = shift;
+
+    my %options = ( public  => 'Allow public access', local => 'Allow local access only',disabled => 'DISABLED');
+
+    return \%options;
+}
+sub get_smtp_ssl_auth_opt {
+
+    my $c = shift;
+
+    return [[ $c->l('Allow public access') => 'public'],
+	    [ $c->l('Allow local access only') => 'local'],
+	    [ $c->l('DISABLED') => 'disabled']
+	    ];
+}
+
+sub get_key_by_value {
+    my ($hash_ref, $target_value) = @_;
+    
+    # Iterate over the hash
+    while (my ($key, $value) = each %$hash_ref) {
+        return $key if $value eq $target_value;
+    }
+    
+    return undef; # Return undef if no match is found
+}
+sub get_value_by_key {
+    my ($hash_ref, $key) = @_;
+    
+    return $hash_ref->{$key}; # Return the value associated with the key
 }


@@ -507,8 +606,7 @@ sub get_webmail_opt {

    return [[ $c->l('DISABLED') => 'disabled' ],
 	    [ $c->l('mai_ENABLED_SECURE_ONLY') => 'enabledSSL' ],
-	    [ $c->l('mai_ONLY_LOCAL_NETWORK_SSL') => 'localnetworkSSL' ],
-	    [ $c->l('mai_ENABLED_BOTH') => 'public' ]];
+	    [ $c->l('mai_ONLY_LOCAL_NETWORK_SSL') => 'localnetworkSSL' ]];

 }

@@ -519,10 +617,10 @@ sub get_webmail_options {

    my %options = ( 
 		disabled   => 'DISABLED', 
-               enabledSSL => 'mai_ENABLED_SECURE_ONLY',
-               localnetworkSSL => 'mai_ONLY_LOCAL_NETWORK_SSL' );
+		enabledSSL => 'mai_ENABLED_SECURE_ONLY',
+		localnetworkSSL => 'mai_ONLY_LOCAL_NETWORK_SSL');

-    \%options;
+    return \%options;
 }


@@ -538,15 +636,6 @@ sub get_retrieval_opt {
 }


-sub get_smtp_auth_opt {
-
-    my $c = shift;
-
-    return [[ $c->l('DISABLED') => 'disabled'],
-	    [ $c->l('mai_SECURE_SMTP') => 'publicSSL'],
-	    [ $c->l('mai_INSECURE_SMTP') => 'public']];
-}
-

 sub get_emailunknownuser_options {

@@ -658,6 +747,7 @@ sub display_multidrop {
 sub change_settings_reception {

    my $c = shift;
+    $cdb = esmith::ConfigDB->open || die "Couldn't open config db";

    my $FetchmailMethod = ( $c->param('FetchmailMethod') || 'standard' );

@@ -701,18 +791,47 @@ sub change_settings_reception {
        }
    }

-    my $smtpAuth = ($c->param('SMTPAuth') || 'public');
-    if ($smtpAuth eq 'public') {
-        $cdb->set_prop("qpsmtpd", "Authentication", "enabled" );
-        $cdb->set_prop("sqpsmtpd", "Authentication", "enabled" );
-    } elsif ($smtpAuth eq 'publicSSL') {
-        $cdb->set_prop("qpsmtpd", "Authentication", "disabled" );
-        $cdb->set_prop("sqpsmtpd", "Authentication", "enabled" );
-    } else {
-        $cdb->set_prop("qpsmtpd", "Authentication", "disabled" );
-        $cdb->set_prop("sqpsmtpd", "Authentication", "disabled" );
-    }
+	# Need code here for all 3 options - 25, 465 ad 587
+	# Options for 25 are enabled and disabled
+	#    for 465 and 587 are (access) public, local and (status) disabled
+	
+    
+    #my $smtpAuth = ($c->param('SMTPAuth') || 'public');
+    #if ($smtpAuth eq 'public') {
+        #$cdb->set_prop("qpsmtpd", "Authentication", "enabled" );
+        #$cdb->set_prop("sqpsmtpd", "Authentication", "enabled" );
+    #} elsif ($smtpAuth eq 'publicSSL') {
+        #$cdb->set_prop("qpsmtpd", "Authentication", "disabled" );
+        #$cdb->set_prop("sqpsmtpd", "Authentication", "enabled" );
+    #} else {
+        #$cdb->set_prop("qpsmtpd", "Authentication", "disabled" );
+        #$cdb->set_prop("sqpsmtpd", "Authentication", "disabled" );
+    #}

+	my @keys = qw(qpsmtpd uqpsmtpd sqpsmtpd);
+
+	foreach my $key (@keys) {
+		my $param_name = $key eq 'qpsmtpd' ? 'SMTPAuth' 
+						  : $key eq 'uqpsmtpd' ? 'uSMTPAuth'
+						  : 'sSMTPAuth';  # Defaults to 'sSMTPAuth' for 'sqpsmtpd'
+		my $SMTPAuth = $c->param($param_name);
+		if ($SMTPAuth eq 'disabled') {
+			$cdb->set_prop($key, 'status', 'disabled');
+			$cdb->set_prop($key, 'access', 'disabled');
+		} else {
+			$cdb->set_prop($key, 'status', 'enabled');
+			if ($key eq 'qpsmtpd') {
+				my $auth_status = $SMTPAuth eq 'publicSSL' ? 'enabled' : 'disabled';
+				$cdb->set_prop($key, 'Authentication', $auth_status);
+				$cdb->set_prop($key, 'access', 'public');
+			} else {
+				$cdb->set_prop($key, 'Authentication', 'enabled');
+				my $auth_key = ($key eq 'uqpsmtpd') ? 'uSMTPAuth' : 'sSMTPAuth';
+				my $access_value = $c->param($auth_key) eq 'public' ? 'public' : 'local';
+				$cdb->set_prop($key, 'access', $access_value);
+			}
+		}
+	}
    unless ( system( "/sbin/e-smith/signal-event", "email-update" ) == 0 )
    {
 	return $c->l('mai_ERROR_UPDATING_CONFIGURATION');
@@ -724,6 +843,7 @@ sub change_settings_reception {
 sub change_settings_delivery {

    my ($c) = shift;
+    $cdb = esmith::ConfigDB->open || die "Couldn't open config db";

    my $EmailUnknownUser = ($c->param('EmailUnknownUser') || 'returntosender');

@@ -752,7 +872,8 @@ sub change_settings_delivery {
 sub change_settings_access {

    my $c = shift;
-
+	$cdb = esmith::ConfigDB->open || die "Couldn't open config db";
+    
    my $pop3Access = ($c->param('POPAccess') || 'private');
    if ($pop3Access eq 'disabled') {
        $cdb->set_prop('pop3', "status", "disabled" );
@@ -802,38 +923,22 @@ sub change_settings_access {
    #------------------------------------------------------------

    my $webmail = ($c->param('WebMail') || 'disabled');
-    if ( $webmail eq "enabled" ) {
-      $cdb->set_prop('php', "status", $webmail );
-      $cdb->set_prop('mariadb',"status", $webmail );
-      $cdb->set_prop('imp',"status", $webmail );
-      $cdb->set_prop('horde', "status", $webmail );
-      $cdb->set_prop('imp',"access", "full" );
-      $cdb->set_prop('horde',"access", "public" );
-      $cdb->set_prop('horde',"HttpsOnly", "no" );
-    }
-    elsif ( $webmail eq "enabledSSL" ) {
-      $cdb->set_prop('php',"status", "enabled" );
+    if ( $webmail eq "enabledSSL" ) {
+      $cdb->set_prop('php81-php-fpm',"status", "enabled" );
      $cdb->set_prop('mariadb',"status", "enabled" );
-      $cdb->set_prop('imp',"status", 'enabled' );
-      $cdb->set_prop('horde',"status", 'enabled' );
-      $cdb->set_prop('imp',"access", "SSL" );
-      $cdb->set_prop('horde',"access", "public" );
-      $cdb->set_prop('horde',"HttpsOnly", "yes" );
+      $cdb->set_prop('roundcube',"status", 'enabled' );
+      $cdb->set_prop('roundcube',"access", "public" );
    }

    elsif ( $webmail eq "localnetworkSSL" ) {
-      $cdb->set_prop('php',"status", "enabled" );
+      $cdb->set_prop('php81-php-fpm',"status", "enabled" );
      $cdb->set_prop('mariadb',"status", "enabled" );
-      $cdb->set_prop('imp',"status", 'enabled' );
-      $cdb->set_prop('horde',"status", 'enabled' );
-      $cdb->set_prop('imp',"access", "SSL" );
-      $cdb->set_prop('horde',"access", "private" );
-      $cdb->set_prop('horde',"HttpsOnly", "yes" );
+      $cdb->set_prop('roundcube',"status", 'enabled' );
+      $cdb->set_prop('roundcube',"access", "private" );
     }

    else {
-      $cdb->set_prop('imp',"status", 'disabled' );
-      $cdb->set_prop('horde',"status", 'disabled' );
+      $cdb->set_prop('roundcube',"status", 'disabled' );
    }

    unless ( system( "/sbin/e-smith/signal-event", "email-update" ) == 0 ) {
@@ -847,6 +952,8 @@ sub change_settings_access {
 sub change_settings_filtering {

    my $c = shift;
+    $cdb = esmith::ConfigDB->open || die "Couldn't open config db";
+

    my $virus_status = ( $c->param('VirusStatus') || 'disabled' );
    $cdb->set_prop("qpsmtpd", 'VirusScan', $virus_status);
@@ -860,7 +967,7 @@ sub change_settings_filtering {
                        Subject
 			SubjectTag) )
    {
-	$cdb->set_prop('spamassassin', $param, $c->param("Spam$param"));
+	  $cdb->set_prop('spamassassin', $param, $c->param("Spam$param"));
    }

    my $patterns_status = $c->adjust_patterns() ? 'enabled' : 'disabled';
@@ -868,7 +975,7 @@ sub change_settings_filtering {

    unless ( system( "/sbin/e-smith/signal-event", "email-update" ) == 0 )
    {
-	return $c->l('mai_ERROR_UPDATING_CONFIGURATION');
+	    return $c->l('mai_ERROR_UPDATING_CONFIGURATION');
    }

    return 'OK';
@@ -922,4 +1029,4 @@ sub validate_smarthost {
 }


-1;
+1;
--- a/root/usr/share/smanager/lib/SrvMngr/Controller/Portforwarding.pm
+++ b/root/usr/share/smanager/lib/SrvMngr/Controller/Portforwarding.pm
@@ -171,9 +171,11 @@ sub add_portforward {
 	#work out which protocol   	
 	my $fdb;
 	if ($proto eq 'TCP') {
+		$tcp_db = esmith::ConfigDB->open('portforward_tcp') || die "Can't open portforward_tcp database: $!\n";
 		$fdb = $tcp_db;
 	}
 	else {
+		$udp_db = esmith::ConfigDB->open('portforward_udp') || die "Can't open portforward_udp database: $!\n";
 		$fdb = $udp_db;
 	}
 	#Get the other values 
--- a/root/usr/share/smanager/lib/SrvMngr/Controller/Remoteaccess.pm
+++ b/root/usr/share/smanager/lib/SrvMngr/Controller/Remoteaccess.pm
@@ -26,165 +26,182 @@ use Socket qw( inet_aton );

 #our @ISA = qw(esmith::FormMagick Exporter);

-our @EXPORT = qw( networkAccess_list passwordLogin_list get_ssh_permit_root_login get_ssh_access get_telnet_mode
-		get_ftp_access  get_ftp_password_login_access
-		get_value get_prop get_ssh_password_auth
-		validate_network_and_mask ip_number_or_blank subnet_mask_or_blank
-		get_ipsecrw_sessions pptp_and_dhcp_range
-);
+our @EXPORT =
+  qw( networkAccess_list passwordLogin_list get_ssh_permit_root_login get_ssh_access get_telnet_mode
+  get_ftp_access  get_ftp_password_login_access
+  get_value get_prop get_ssh_password_auth
+  validate_network_and_mask ip_number_or_blank subnet_mask_or_blank
+  get_ipsecrw_sessions pptp_and_dhcp_range
+  );
+
 #		get_pptp_sessions

 our $db = esmith::ConfigDB->open || warn "Couldn't open configuration database";

-
 sub main {

    my $c = shift;
-    $c->app->log->info($c->log_req);
+    $c->app->log->info( $c->log_req );

-    my $title = $c->l('rma_FORM_TITLE');
-    my $notif = '';
+    my $title     = $c->l('rma_FORM_TITLE');
+    my $notif     = '';
    my %rma_datas = ();

+	$db = esmith::ConfigDB->open || warn "Couldn't open configuration database";
+
    #$rma_datas{ipsecrwSess}  = $c->get_ipsecrw_sessions();
    #$rma_datas{pptpSessions} = $c->get_pptp_sessions();
-    $rma_datas{sshAccess} = $c->get_ssh_access();
-    $rma_datas{sshPermitRootLogin} = $c->get_ssh_permit_root_login();
+    $rma_datas{sshAccess}                 = $c->get_ssh_access();
+    $rma_datas{sshPermitRootLogin}        = $c->get_ssh_permit_root_login();
    $rma_datas{sshPasswordAuthentication} = $c->get_ssh_password_auth();
-    $rma_datas{sshTCPPort} = $c->get_ssh_port();
-    $rma_datas{ftpAccess} = $c->get_ftp_access();
-    $rma_datas{ftpPasswordAccess} = $c->get_ftp_password_login_access();
+    $rma_datas{sshTCPPort}                = $c->get_ssh_port();
+    $rma_datas{ftpAccess}                 = $c->get_ftp_access();
+    $rma_datas{ftpPasswordAccess}         = $c->get_ftp_password_login_access();
+
    #$rma_datas{telnetAccess} = $c->get_telnet_access;

    $c->stash( title => $title, notif => $notif, rma_datas => \%rma_datas );
-    $c->render(template => 'remoteaccess');
-
-};
+    $c->render( template => 'remoteaccess' );

+}

 sub do_action {

    my $c = shift;
-    $c->app->log->info($c->log_req);
+    $c->app->log->info( $c->log_req );

    my $title = $c->l('rma_FORM_TITLE');
-    my ($result, $res, $trt) = '';
+    my ( $result, $res, $trt ) = '';
    my %rma_datas = ();

-    $rma_datas{ipsecrwSess}  = ($c->param ('IpsecrwSess') || '');
-    $rma_datas{ipsecrwReset}  = ($c->param ('IpsecrwReset') || '');
+	$db = esmith::ConfigDB->open || warn "Couldn't open configuration database";
+
+    $rma_datas{ipsecrwSess}  = ( $c->param('IpsecrwSess')  || '' );
+    $rma_datas{ipsecrwReset} = ( $c->param('IpsecrwReset') || '' );

    #$rma_datas{pptpSessions} = ($c->param ('PptpSessions') || '0');

-    $rma_datas{validFromNetwork} = ($c->param ('ValidFromNetwork') || '');
-    $rma_datas{validFromMask} = ($c->param ('ValidFromMask') || '');
+    $rma_datas{validFromNetwork} = ( $c->param('ValidFromNetwork') || '' );
+    $rma_datas{validFromMask}    = ( $c->param('ValidFromMask')    || '' );
 ##	my @remove = $q->param('validFromRemove');  ???????? the first one only !!
-    my @vals = $c->param ('Remove_nets');
+    my @vals = $c->param('Remove_nets');
    $rma_datas{remove_nets} = join ',', @vals;

-    $rma_datas{sshaccess} = ($c->param ('SshAccess') || 'off');
-    $rma_datas{sshPermitRootLogin} = ($c->param ('SshPermitRootLogin') || 'no');
-    $rma_datas{sshPasswordAuthentication} = ($c->param ('SshPasswordAuthentication') || 'no');
-    $rma_datas{sshTCPPort} = ($c->param ('SshTCPPort') || '22');
+    $rma_datas{sshaccess} = ( $c->param('SshAccess') || 'off' );
+    $rma_datas{sshPermitRootLogin} =
+      ( $c->param('SshPermitRootLogin') || 'no' );
+    $rma_datas{sshPasswordAuthentication} =
+      ( $c->param('SshPasswordAuthentication') || 'no' );
+    $rma_datas{sshTCPPort} = ( $c->param('SshTCPPort') || '22' );

-    $rma_datas{ftpAccess} = ($c->param ('FtpAccess') || 'off');
-    $rma_datas{ftpPasswordAccess} = ($c->param ('FtpPasswordAccess') || 'private');
+    $rma_datas{ftpAccess} = ( $c->param('FtpAccess') || 'off' );
+    $rma_datas{ftpPasswordAccess} =
+      ( $c->param('FtpPasswordAccess') || 'private' );

-    $rma_datas{telnetAccess} = ($c->param ('TelnetAccess') || 'off');
+    $rma_datas{telnetAccess} = ( $c->param('TelnetAccess') || 'off' );

    # validate
    my $v = $c->validation;
    return $c->render('remoteaccess') unless $v->has_data;

    #$v->optional('PptpSessions')->num(0, 999)->is_valid;
-    $v->optional('ValidFromNetwork')->size(7, 15)->is_valid;
-    $v->optional('ValidFromMask')->size(7, 15)->is_valid;
-    $v->required('SshTCPPort')->num(1, 65535)->is_valid;
+    if ( $c->param('ValidFromNetwork') ne "" ) {
+        $v->optional('ValidFromNetwork')->size( 7, 15 )->is_valid;
+    }
+    if ( $c->param('ValidFromMask') ne "" ) {
+        $v->optional('ValidFromMask')->size( 7, 15 )->is_valid;
+    }
+    $v->required('SshTCPPort')->num( 1, 65535 )->is_valid;

    $result .= 'field validation error' if $v->has_error;

-    if ( ! $result ) {
+    if ( !$result ) {

-	# controls
-	#$res = pptp_and_dhcp_range( $c, $rma_datas{pptpSessions} );
-	#$result .= $res . ' ' unless $res eq 'OK';
+        # controls
+        #$res = pptp_and_dhcp_range( $c, $rma_datas{pptpSessions} );
+        #$result .= $res . ' ' unless $res eq 'OK';

-	$res = ip_number_or_blank( $c, $rma_datas{validFromNetwork} );
-	$result .= $res . ' ' unless $res eq 'OK';
+        $res = ip_number_or_blank( $c, $rma_datas{validFromNetwork} );
+        $result .= $res . ' ' unless $res eq 'OK';

-	$res = subnet_mask_or_blank( $c, $rma_datas{validFromMask} );
-	$result .= $res . ' ' unless $res eq 'OK';
+        $res = subnet_mask_or_blank( $c, $rma_datas{validFromMask} );
+        $result .= $res . ' ' unless $res eq 'OK';

-	$res = validate_network_and_mask( $c, $rma_datas{validFromNetwork}, $rma_datas{validFromMask} );
-	$result .= $res . ' ' unless $res eq 'OK';
+        $res = validate_network_and_mask(
+            $c,
+            $rma_datas{validFromNetwork},
+            $rma_datas{validFromMask}
+        );
+        $result .= $res . ' ' unless $res eq 'OK';

-	#$result .= ' blocked for testing !' . $rma_datas{remove_nets};
+        #$result .= ' blocked for testing !' . $rma_datas{remove_nets};
    }

-    if ( ! $result ) {
+    if ( !$result ) {
        $res = change_settings( $c, %rma_datas );
        $result .= $res unless $res eq 'OK';
    }
-
-    if ( ! $result ) {
-        $result = $c->l('rma_ACTION_SUCCEEDED'); 
-        $trt = 'SUC';
+    
+    if ( $result eq "" ) {
+        $result = $c->l('rma_SUCCESS');
+        $trt    = 'SUC';
    }
-
    $c->stash( title => $title, notif => $result, rma_datas => \%rma_datas );

-    if ( $trt ne 'SUC' ) {
-	return $c->render(template => 'remoteaccess');
+    #return $c->render( template => 'remoteaccess' );
+
+    if ( $trt eq 'SUC' ) {
+		$c->stash( title => $title,modul => $result);
+        return $c->render( template => 'module' );
    }

-    $c->redirect_to('/remoteaccess');
-
-};
+    return $c->render( template => 'remoteaccess' );
+    #$c->redirect_to('/remoteaccess');

+}

 sub networkAccess_list {
    my $c = shift;
-    return  [[ $c->l('rma_NO_ACCESS') => 'off'], 
-	    [ $c->l('NETWORKS_ALLOW_LOCAL') => 'private'], 
-	    [ $c->l('NETWORKS_ALLOW_PUBLIC') => 'public']];
+    return [
+        [ $c->l('rma_NO_ACCESS')         => 'off' ],
+        [ $c->l('NETWORKS_ALLOW_LOCAL')  => 'private' ],
+        [ $c->l('NETWORKS_ALLOW_PUBLIC') => 'public' ]
+    ];
 }

-
 sub passwordLogin_list {
    my $c = shift;
-    return  [[$c->l('rma_PASSWORD_LOGIN_PRIVATE') => 'private'],
-	     [$c->l('rma_PASSWORD_LOGIN_PUBLIC') => 'public']];
+    return [
+        [ $c->l('rma_PASSWORD_LOGIN_PRIVATE') => 'private' ],
+        [ $c->l('rma_PASSWORD_LOGIN_PUBLIC')  => 'public' ]
+    ];
 }

-
 sub get_prop {

-  my ($c, $item, $prop) = @_;
-  warn "You must specify a record key"    unless $item;
-  warn "You must specify a property name" unless $prop;
-  my $record = $db->get($item) or warn "Couldn't get record for $item";
-  return $record ? $record->prop($prop) : undef;
+    my ( $c, $item, $prop ) = @_;
+    warn "You must specify a record key"    unless $item;
+    warn "You must specify a property name" unless $prop;
+    my $record = $db->get($item) or warn "Couldn't get record for $item";
+    return $record ? $record->prop($prop) : undef;
 }

-
 sub get_value {

-  my $c = shift;
-  my $item = shift;
-  return ($db->get($item)->value());
+    my $c    = shift;
+    my $item = shift;
+    return ( $db->get($item)->value() );
 }

-
 sub get_ftp_access {

-    my $status = get_prop('','ftp','status') || 'disabled';
+    my $status = get_prop( '', 'ftp', 'status' ) || 'disabled';
    return 'off' unless $status eq 'enabled';

-    my $access = get_prop('','ftp','access') || 'private';
-    return ($access  eq 'public') ? 'normal' : 'private';
+    my $access = get_prop( '', 'ftp', 'access' ) || 'private';
+    return ( $access eq 'public' ) ? 'normal' : 'private';
 }

-
 #sub get_pptp_sessions {
 #  my $status = get_prop('','pptpd','status');
 #  if (defined($status) && ($status eq 'enabled')) {
@@ -192,314 +209,317 @@ sub get_ftp_access {
 #  return '0';
 #}

-
 sub get_ssh_permit_root_login {
-    return(get_prop('','sshd','PermitRootLogin') || 'no');
+    return ( get_prop( '', 'sshd', 'PermitRootLogin' ) || 'no' );
 }

-
 sub get_ssh_password_auth {
-    return(get_prop('','sshd','PasswordAuthentication') || 'yes');
+    return ( get_prop( '', 'sshd', 'PasswordAuthentication' ) || 'yes' );
 }

-
 sub get_ssh_access {

-  my $status = get_prop('','sshd','status');
-  if (defined($status) && ($status eq 'enabled')) {
-    my $access = get_prop('','sshd','access');
-    $access = ($access eq 'public') ? 'public' : 'private';
-    return($access);
-  }
-  else {
-    return('off');
-  }
+    my $status = get_prop( '', 'sshd', 'status' );
+    if ( defined($status) && ( $status eq 'enabled' ) ) {
+        my $access = get_prop( '', 'sshd', 'access' );
+        $access = ( $access eq 'public' ) ? 'public' : 'private';
+        return ($access);
+    }
+    else {
+        return ('off');
+    }
 }

-
 sub get_ssh_port {
-    return(get_prop('$c','sshd','TCPPort') || '22');
+    return ( get_prop( '$c', 'sshd', 'TCPPort' ) || '22' );
 }

-
 sub get_ftp_password_login_access {

-    my $status = get_prop('','ftp','status') || 'disabled';
+    my $status = get_prop( '', 'ftp', 'status' ) || 'disabled';
    return 'private' unless $status eq 'enabled';

-    my $access = get_prop('','ftp','LoginAccess') || 'private';
+    my $access = get_prop( '', 'ftp', 'LoginAccess' ) || 'private';

-    return ($access  eq 'public') ? 'public' : 'private';
+    return ( $access eq 'public' ) ? 'public' : 'private';
 }

-
 sub get_telnet_mode {

-  my $telnet = $db->get('telnet');
-  return('off') unless $telnet;
-  my $status = $telnet->prop('status') || 'disabled';
-  return('off') unless $status eq 'enabled';
-  my $access = $telnet->prop('access') || 'private';
-  return ($access eq "public") ? "public" : "private";
+    my $telnet = $db->get('telnet');
+    return ('off') unless $telnet;
+    my $status = $telnet->prop('status') || 'disabled';
+    return ('off') unless $status eq 'enabled';
+    my $access = $telnet->prop('access') || 'private';
+    return ( $access eq "public" ) ? "public" : "private";
 }

+sub get_ipsecrw_sessions {

-sub get_ipsecrw_sessions  {
-
-  my $status = $db->get('ipsec')->prop('RoadWarriorStatus');
-  if (defined($status) && ($status eq 'enabled')) {
-    return($db->get('ipsec')->prop('RoadWarriorSessions') || '0');
-  }
-  else {
-    return('0');
-  }
+    my $status = $db->get('ipsec')->prop('RoadWarriorStatus');
+    if ( defined($status) && ( $status eq 'enabled' ) ) {
+        return ( $db->get('ipsec')->prop('RoadWarriorSessions') || '0' );
+    }
+    else {
+        return ('0');
+    }
 }

-
 sub get_ipsecrw_status {

-  return undef unless ( $db->get('ipsec'));
-  return $db->get('ipsec')->prop('RoadWarriorStatus');
+    return undef unless ( $db->get('ipsec') );
+    return $db->get('ipsec')->prop('RoadWarriorStatus');

 }

-
 sub pptp_and_dhcp_range {

-  my $c = shift;
-  my $val = shift || 0;
-  my $dhcp_status     = $db->get_prop('dhcpd','status') || 'disabled';
-  my $dhcp_end        = $db->get_prop('dhcpd','end') || '';
-  my $dhcp_start      = $db->get_prop('dhcpd','start') || '';
+    my $c           = shift;
+    my $val         = shift || 0;
+    my $dhcp_status = $db->get_prop( 'dhcpd', 'status' ) || 'disabled';
+    my $dhcp_end    = $db->get_prop( 'dhcpd', 'end' )    || '';
+    my $dhcp_start  = $db->get_prop( 'dhcpd', 'start' )  || '';

    if ( $dhcp_status eq 'enabled' ) {
-        my $ip_start     = unpack 'N', inet_aton($dhcp_start);
-        my $ip_end       = unpack 'N', inet_aton($dhcp_end);
-        my $ip_count     = $ip_end - $ip_start;
-        return 'OK' if( $val < $ip_count );
-        return $c->l('rma_NUMBER_OF_PPTP_CLIENTS_MUST_BE_LESSER_THAN_NUMBER_OF_IP_IN_DHCP_RANGE');
-    } else {
+        my $ip_start = unpack 'N', inet_aton($dhcp_start);
+        my $ip_end   = unpack 'N', inet_aton($dhcp_end);
+        my $ip_count = $ip_end - $ip_start;
+        return 'OK' if ( $val < $ip_count );
+        return $c->l(
+'rma_NUMBER_OF_PPTP_CLIENTS_MUST_BE_LESSER_THAN_NUMBER_OF_IP_IN_DHCP_RANGE'
+        );
+    }
+    else {
        return 'OK';
    }
 }

-
 sub _get_valid_from {

-	my $c = shift;
+    my $c = shift;

-	my $rec = $db->get('httpd-admin');
-	return undef unless($rec);
-	my @vals = (split ',', ($rec->prop('ValidFrom') || ''));
-	return @vals;
+    my $rec = $db->get('httpd-admin');
+    return undef unless ($rec);
+    my @vals = ( split ',', ( $rec->prop('ValidFrom') || '' ) );
+    return @vals;
 }

-
 sub ip_number_or_blank {

-    my $c = shift;
+    my $c  = shift;
    my $ip = shift;

-    if (!defined($ip) || $ip eq "") {
-	return 'OK';
+    if ( !defined($ip) || $ip eq "" ) {
+        return 'OK';
    }
-    return ip_number($c, $ip);
+    return ip_number( $c, $ip );
 }

-
 sub subnet_mask_or_blank {

-    my $c = shift;
+    my $c    = shift;
    my $mask = shift;

-    if (!defined($mask) || $mask eq "") {
+    if ( !defined($mask) || $mask eq "" ) {
        return "OK";
    }

-    chomp $mask ;
+    chomp $mask;

-    return ( subnet_mask( $mask ) ne 'OK' ) ? $c->l('rma_INVALID_SUBNET_MASK') . " (" . $mask . ")" : 'OK';
+    return ( subnet_mask($mask) ne 'OK' )
+      ? $c->l('rma_INVALID_SUBNET_MASK') . " (" . $mask . ")"
+      : 'OK';
 }

-
 sub validate_network_and_mask {

-  my $c = shift;
-  my $net = shift  || "";
-  my $mask = shift || "";
+    my $c    = shift;
+    my $net  = shift || "";
+    my $mask = shift || "";

-  if ($net xor $mask) {
-    return $c->l('rma_ERR_INVALID_PARAMS' . " (" . $net."/".$mask . ")");
-  }
-  return 'OK';
+    if ( $net xor $mask ) {
+        return $c->l(
+            'rma_ERR_INVALID_PARAMS' . " (" . $net . "/" . $mask . ")" );
+    }
+    return 'OK';
 }

-
 sub change_settings {

-    my ($c, %rma_datas) = @_;
+    my ( $c, %rma_datas ) = @_;

    #------------------------------------------------------------
    # good; go ahead and change the access.
    #------------------------------------------------------------

    my $rec = $db->get('telnet');
-    if($rec) {
-    	if ($rma_datas{telnetAccess} eq "off") {
-	    $rec->set_prop('status','disabled');
-    	} else {
-	    $rec->set_prop('status','enabled');
-	    $rec->set_prop('access', $rma_datas{telnetAccess});
-      	}
+    if ($rec) {
+        if ( $rma_datas{telnetAccess} eq "off" ) {
+            $rec->set_prop( 'status', 'disabled' );
+        }
+        else {
+            $rec->set_prop( 'status', 'enabled' );
+            $rec->set_prop( 'access', $rma_datas{telnetAccess} );
+        }
    }

-    $rec = $db->get('sshd') || $db->new_record('sshd', {type => 'service'});
-    $rec->set_prop('TCPPort', $rma_datas{sshTCPPort});
-    $rec->set_prop('status', ( $rma_datas{sshaccess} eq "off" ? 'disabled' : 'enabled'));
-    $rec->set_prop('access', $rma_datas{sshaccess});
-    $rec->set_prop('PermitRootLogin', $rma_datas{sshPermitRootLogin});
-    $rec->set_prop('PasswordAuthentication', $rma_datas{sshPasswordAuthentication});
-
+    $rec = $db->get('sshd') || $db->new_record( 'sshd', { type => 'service' } );
+    $rec->set_prop( 'TCPPort', $rma_datas{sshTCPPort} );
+    $rec->set_prop( 'status',
+        ( $rma_datas{sshaccess} eq "off" ? 'disabled' : 'enabled' ) );
+    $rec->set_prop( 'access',          $rma_datas{sshaccess} );
+    $rec->set_prop( 'PermitRootLogin', $rma_datas{sshPermitRootLogin} );
+    $rec->set_prop( 'PasswordAuthentication',
+        $rma_datas{sshPasswordAuthentication} );

    $rec = $db->get('ftp');
-    if($rec) {
-    	if ($rma_datas{ftpAccess} eq "off") {
-	    $rec->set_prop('status', 'disabled');
-	    $rec->set_prop('access', 'private');
-	    $rec->set_prop('LoginAccess', 'private');
-    	} elsif ($rma_datas{ftpAccess} eq "normal") {
-	    $rec->set_prop('status', 'enabled');
-	    $rec->set_prop('access', 'public');
-	    $rec->set_prop('LoginAccess', $rma_datas{ftpPasswordAccess});
-    	} else {
-	    $rec->set_prop('status', 'enabled');
-	    $rec->set_prop('access', 'private');
-	    $rec->set_prop('LoginAccess', $rma_datas{ftpPasswordAccess});
-    	}
+    if ($rec) {
+        if ( $rma_datas{ftpAccess} eq "off" ) {
+            $rec->set_prop( 'status',      'disabled' );
+            $rec->set_prop( 'access',      'private' );
+            $rec->set_prop( 'LoginAccess', 'private' );
+        }
+        elsif ( $rma_datas{ftpAccess} eq "normal" ) {
+            $rec->set_prop( 'status',      'enabled' );
+            $rec->set_prop( 'access',      'public' );
+            $rec->set_prop( 'LoginAccess', $rma_datas{ftpPasswordAccess} );
+        }
+        else {
+            $rec->set_prop( 'status',      'enabled' );
+            $rec->set_prop( 'access',      'private' );
+            $rec->set_prop( 'LoginAccess', $rma_datas{ftpPasswordAccess} );
+        }
    }

-#	if ($rma_datas{pptpSessions} == 0) {
-#	$db->get('pptpd')->set_prop('status', 'disabled');
-#    } else {
-#	$db->get('pptpd')->set_prop('status', 'enabled');
-#	$db->get('pptpd')->set_prop('sessions', $rma_datas{pptpSessions});
-#    }
+    #	if ($rma_datas{pptpSessions} == 0) {
+    #	$db->get('pptpd')->set_prop('status', 'disabled');
+    #    } else {
+    #	$db->get('pptpd')->set_prop('status', 'enabled');
+    #	$db->get('pptpd')->set_prop('sessions', $rma_datas{pptpSessions});
+    #    }

    if ( $rma_datas{validFromNetwork} && $rma_datas{validFromMask} ) {
-	unless (add_new_valid_from( $c, $rma_datas{validFromNetwork}, $rma_datas{validFromMask} )) {
-	    return $c->l('rma_ERROR_UPDATING_CONFIGURATION') . 'new net';
-	}
+        unless (
+            add_new_valid_from(
+                $c,
+                $rma_datas{validFromNetwork},
+                $rma_datas{validFromMask}
+            )
+          )
+        {
+            return $c->l('rma_ERROR_UPDATING_CONFIGURATION') . 'new net';
+        }
    }

-
    if ( $rma_datas{remove_nets} ) {
-	unless (remove_valid_from( $c, $rma_datas{remove_nets} )) {
-	    return $c->l('rma_ERROR_UPDATING_CONFIGURATION') . 'del net';
-	}
+        unless ( remove_valid_from( $c, $rma_datas{remove_nets} ) ) {
+            return $c->l('rma_ERROR_UPDATING_CONFIGURATION') . 'del net';
+        }
    }
-  
+
    # reset ipsec roadwarrior CA,server,client certificates
-    if ($rma_datas{ipsecrwReset}) {
-	system('/sbin/e-smith/roadwarrior', 'reset_certs') == 0 or
-	    return $c->l('rma_ERROR_UPDATING_CONFIGURATION') . 'rst ipsec';
+    if ( $rma_datas{ipsecrwReset} ) {
+        system( '/sbin/e-smith/roadwarrior', 'reset_certs' ) == 0
+          or return $c->l('rma_ERROR_UPDATING_CONFIGURATION') . 'rst ipsec';
    }

    if ( $rma_datas{ipsecrwSess} ) {
-	set_ipsecrw_sessions( $c, $rma_datas{ipsecrwSess} );
+        set_ipsecrw_sessions( $c, $rma_datas{ipsecrwSess} );
    }

-    unless ( system( "/sbin/e-smith/signal-event", "remoteaccess-update" ) == 0 ) {
+    unless (
+        system( "/sbin/e-smith/signal-event", "remoteaccess-update" ) == 0 )
+    {
        return $c->l('rma_ERROR_UPDATING_CONFIGURATION');
    }

    return 'OK';
 }

-
 sub set_ipsecrw_sessions {

-    my $c = shift;
+    my $c        = shift;
    my $sessions = shift;

-    if (defined $sessions) {
-	$db->get('ipsec')->set_prop('RoadWarriorSessions', $sessions);
-	if (int($sessions) > 0) {
-	    $db->get('ipsec')->set_prop('RoadWarriorStatus', 'enabled');
-	}
+    if ( defined $sessions ) {
+        $db->get('ipsec')->set_prop( 'RoadWarriorSessions', $sessions );
+        if ( int($sessions) > 0 ) {
+            $db->get('ipsec')->set_prop( 'RoadWarriorStatus', 'enabled' );
+        }
    }
    return '';
 }

-
 sub add_new_valid_from {

-	my $c = shift;
-	my $net = shift;
-	my $mask = shift;
+    my $c    = shift;
+    my $net  = shift;
+    my $mask = shift;

-	# we transform bit mask to regular mask
-	$mask = get_reg_mask( $net, $mask );
- 
-	my $rec = $db->get('httpd-admin');
-	return $c->error('ERR_NO_RECORD') unless $rec;
+    # we transform bit mask to regular mask
+    $mask = get_reg_mask( $net, $mask );

-	my $prop = $rec->prop('ValidFrom') || '';
+    my $rec = $db->get('httpd-admin');
+    return $c->error('ERR_NO_RECORD') unless $rec;

-	my @vals = split /,/, $prop;
-	return '' if (grep /^$net\/$mask$/, @vals); # already have this entry
+    my $prop = $rec->prop('ValidFrom') || '';

-	if ($prop ne '') {
-		$prop .= ",$net/$mask";
-	} else {
-		$prop = "$net/$mask";
-	}
+    my @vals = split /,/, $prop;
+    return '' if ( grep /^$net\/$mask$/, @vals );    # already have this entry

-	$rec->set_prop('ValidFrom', $prop);
+    if ( $prop ne '' ) {
+        $prop .= ",$net/$mask";
+    }
+    else {
+        $prop = "$net/$mask";
+    }

-	return 1;
+    $rec->set_prop( 'ValidFrom', $prop );
+
+    return 1;
 }

-
 sub remove_valid_from {

-	my $c = shift;
-	my $remove_nets = shift;
+    my $c           = shift;
+    my $remove_nets = shift;

-	my @remove = split /,/, $remove_nets;
+    my @remove = split /,/, $remove_nets;

-#	my @remove = $c->param('Remove_nets');
-	my @vals = $c->_get_valid_from();
+    #	my @remove = $c->param('Remove_nets');
+    my @vals = $c->_get_valid_from();

-	foreach my $entry (@remove) {
-	
-	    return undef unless $entry;
+    foreach my $entry (@remove) {

-	    my ($net, $mask) = split (/\//, $entry);
+        return undef unless $entry;

-	    unless (@vals)  {
-		print STDERR "ERROR: unable to load ValidFrom property from conf db\n";
-		return undef;
-	    }
+        my ( $net, $mask ) = split( /\//, $entry );

-	    # what if we don't have a mask because someone added an entry from
-	    # the command line? by the time we get here, the panel will have
-	    # added a 32 bit mask, so we don't know for sure if the value in db
-	    # is $net alone or $net/255.255.255.255. we have to check for both
-	    # in this special case...
-	    @vals = (grep { $entry ne $_ && $net ne $_ } @vals);
-	}
+        unless (@vals) {
+            print STDERR
+              "ERROR: unable to load ValidFrom property from conf db\n";
+            return undef;
+        }

-	my $prop;
-	if (@vals) {
-	    $prop = join ',',@vals;
-	} else {
-	    $prop = '';
-	}
+        # what if we don't have a mask because someone added an entry from
+        # the command line? by the time we get here, the panel will have
+        # added a 32 bit mask, so we don't know for sure if the value in db
+        # is $net alone or $net/255.255.255.255. we have to check for both
+        # in this special case...
+        @vals = ( grep { $entry ne $_ && $net ne $_ } @vals );
+    }

-	$db->get('httpd-admin')->set_prop('ValidFrom', $prop);
+    my $prop;
+    if (@vals) {
+        $prop = join ',', @vals;
+    }
+    else {
+        $prop = '';
+    }

-	return 1;
+    $db->get('httpd-admin')->set_prop( 'ValidFrom', $prop );
+
+    return 1;
 }

-
-1;
+1;
--- a/root/usr/share/smanager/lib/SrvMngr/Controller/Roundcubepanel.pm
+++ b/root/usr/share/smanager/lib/SrvMngr/Controller/Roundcubepanel.pm
@@ -0,0 +1,46 @@
+package SrvMngr::Controller::Roundcubepanel;
+
+#----------------------------------------------------------------------
+# heading     : System
+# description : Roundcube webmail
+# navigation  : 99999 9999
+#----------------------------------------------------------------------
+#----------------------------------------------------------------------
+# name   : roundcubepanel,    method : get,   url : /roundcubepanel,     ctlact : Roundcubepanel#main
+#
+# routes : end
+#----------------------------------------------------------------------
+
+use strict;
+use warnings;
+
+use Mojo::Base 'Mojolicious::Controller';
+
+use Locale::gettext;
+use SrvMngr::I18N;
+use SrvMngr qw(theme_list init_session);
+
+#use SrvMngr::Model::Main;
+
+
+sub main {
+
+    my $c = shift;
+    $c->app->log->info($c->log_req);
+
+    my $title = $c->l('Roundcube Webmail');
+    my $roundcube_url = $c->param('url');
+    my $roundcube_height = $c->param('height') | 600;
+    $c->stash( title => $title, modul => $roundcube_url, height => $roundcube_height );
+    $c->render(template => 'roundcube');
+
+}
+
+sub getroundcubeurl {
+	my $c = shift;
+	my $url = shift;
+	return "/smanager/roundcube?url=$url";
+}
+
+
+1;
--- a/root/usr/share/smanager/lib/SrvMngr/Controller/Yum.pm
+++ b/root/usr/share/smanager/lib/SrvMngr/Controller/Yum.pm
@@ -23,14 +23,16 @@ use File::Basename;

 our $cdb = esmith::ConfigDB->open || die "Couldn't open config db";

+my $dnf_status_file  = '/var/cache/dnf/dnf.status';
+
 #use File::stat;

 our %dbs;

 for ( qw(available installed updates) )
 {
-    $dbs{$_} = esmith::ConfigDB->open_ro("yum_$_") or
-	die "Couldn't open yum_$_ DB\n";
+    $dbs{$_} = esmith::ConfigDB->open_ro("dnf_$_") or
+	die "Couldn't open dnf_$_ DB\n";
 }

 for ( qw(repositories) )
@@ -52,10 +54,11 @@ sub main {

    $yum_datas{'trt'} = 'STAT';

-    if ( -e "/var/run/yum.pid" ) {
+   
+    if ( $c->is_dnf_running()) {
 	$yum_datas{'trt'} = 'LOGF';
 	$dest = 'yumlogfile';
-    } elsif ($cdb->get_prop('yum', 'LogFile')) {
+    } elsif ($cdb->get_prop('dnf', 'LogFile')) {
 	$yum_datas{'trt'} = 'PSTU';
 	$yum_datas{'reconf'} = $cdb->get_value('UnsavedChanges', 'yes');
 	$dest = 'yumpostupg';
@@ -83,9 +86,9 @@ sub do_display {
    $yum_datas{'trt'} = $trt;

    # force $trt if current logfile
-    if ( -e "/var/run/yum.pid" ) {
+    if ( $c->is_dnf_running() ) {
 	$trt = 'LOGF';
-    } elsif ($cdb->get_prop('yum', 'LogFile')) {
+    } elsif ($cdb->get_prop('dnf', 'LogFile')) {
 	$trt = 'PSTU';
    }

@@ -106,13 +109,13 @@ sub do_display {
 	}

        if ( $trt eq 'LOGF' ) {
-	    if (-e "/var/run/yum.pid") {
+	    if ($c->is_dnf_running()) {
 	    $dest = 'yumlogfile';
 	    }
 	}
 	
        if ( $trt eq 'PSTU') {
-	    if ($cdb->get_prop('yum', 'LogFile')) {
+	    if ($cdb->get_prop('dnf', 'LogFile')) {
 		$dest = 'yumpostupg';
 		$yum_datas{'reconf'} = $cdb->get_value('UnsavedChanges', 'yes');
 	    }
@@ -221,7 +224,7 @@ sub do_update {
    if ( $trt eq 'LOGF' ) {

    	$dest = 'yumlogfile';
-        if ( ! -e "/var/run/yum.pid") {
+        if ( ! $c->is_dnf_running()) {
 	    $yum_datas{trt} = 'SUC';
 	    $result = $c->l('yum_SUCCESS');
        }
@@ -247,6 +250,24 @@ sub do_update {

 };

+sub get_dnf_status {
+    #interrogate status file created and maintained by smeserver.py plugin for dnf.
+    my ($c) = @_;
+    my $file_name = $dnf_status_file;
+    my $content = "resolved";
+    if ( -e "$file_name") {
+	open my $fh, '<', $file_name or die "Can't open file: $!";
+	$content = <$fh>;
+	close $fh;
+    }
+    return $content;
+}
+
+sub is_dnf_running {
+    my ($c) = @_;
+    my $dnf_status = $c->get_dnf_status();
+    return $dnf_status ne "resolved" && $dnf_status ne "config" && $dnf_status ne "sack";
+}

 sub is_empty {

@@ -289,7 +310,7 @@ sub package_functions_enabled {

    my ($c) = @_;

-    return ($cdb->get_prop("yum", "PackageFunctions") eq "enabled");
+    return ($cdb->get_prop("dnf", "PackageFunctions") eq "enabled");

 }

@@ -298,7 +319,7 @@ sub get_status {

    my ($c, $prop, $localise) = @_;

-    my $status = $cdb->get_prop("yum", $prop) || 'disabled';
+    my $status = $cdb->get_prop("dnf", $prop) || 'disabled';

    return $status unless $localise;

@@ -433,7 +454,7 @@ sub change_settings {
 			PackageFunctions
            	) )
    {
-	$cdb->set_prop('yum', $param, $c->param("yum_$param"));
+	$cdb->set_prop("dnf", $param, $c->param("yum_$param"));
    }

    my $check4updates = $c->param("yum_check4updates");
@@ -441,21 +462,21 @@ sub change_settings {

    if ($check4updates ne 'disabled') { $status = 'enabled'; }

-    $cdb->set_prop('yum', 'check4updates', $check4updates);
+    $cdb->set_prop("dnf", 'check4updates', $check4updates);

    my $deltarpm = $c->param("yum_DeltaRpmProcess");
-    $cdb->set_prop('yum', 'DeltaRpmProcess', $deltarpm);
+    $cdb->set_prop("dnf", 'DeltaRpmProcess', $deltarpm);

    my $downloadonly = $c->param("yum_DownloadOnly");
    if ($downloadonly ne 'disabled') { $status = 'enabled'; }

-    $cdb->set_prop('yum', 'DownloadOnly', $downloadonly);
+    $cdb->set_prop("dnf", 'DownloadOnly', $downloadonly);

    my $AutoInstallUpdates = $c->param("yum_AutoInstallUpdates");
    if ($AutoInstallUpdates ne 'disabled') { $status = 'enabled'; }

-    $cdb->set_prop('yum', 'AutoInstallUpdates', $AutoInstallUpdates);
-    $cdb->set_prop('yum', 'status', $status);
+    $cdb->set_prop("dnf", 'AutoInstallUpdates', $AutoInstallUpdates);
+    $cdb->set_prop("dnf", 'status', $status);

    my %selected = map {$_ => 1} @{$c->every_param('SelectedRepositories')};

@@ -469,7 +490,7 @@ sub change_settings {

    $dbs{repositories}->reload;

-    unless ( system( "/sbin/e-smith/signal-event", "yum-modify" ) == 0 )
+    unless ( system( "/sbin/e-smith/signal-event", "dnf-modify" ) == 0 )
    {
 	return $c->l('yum_ERROR_UPDATING_CONFIGURATION');
    }
@@ -484,11 +505,11 @@ sub do_yum {

    for ( qw(SelectedGroups SelectedPackages) )
    {
-	$cdb->set_prop("yum", $_, join(',', (@{$c->every_param($_)} )));
+	$cdb->set_prop("dnf", $_, join(',', (@{$c->every_param($_)} )));
    }

    esmith::util::backgroundCommand(0,
-        "/sbin/e-smith/signal-event", "yum-$function");
+        "/sbin/e-smith/signal-event", "dnf-$function");

    for ( qw(available installed updates) ) {
 	$dbs{$_}->reload;
@@ -517,7 +538,7 @@ sub format_yum_log {

    $cdb->reload;

-    my $filepage = $cdb->get_prop('yum', 'LogFile');
+    my $filepage = $cdb->get_prop('dnf', 'LogFile');
    return '' unless $filepage and ( -e "$filepage" );

    my $out = sprintf "<PRE>";
@@ -537,7 +558,7 @@ sub post_upgrade_reboot {

    my $c = shift;

-    $cdb->get_prop_and_delete('yum', 'LogFile');
+    $cdb->get_prop_and_delete('dnf', 'LogFile');
    $cdb->reload;

    if (fork == 0) {
@@ -552,7 +573,7 @@ sub post_upgrade_reboot {
 sub show_yum_log {
    my $c = shift;
    my $out = $c->format_yum_log();
-    my $yum_log = $cdb->get_prop_and_delete('yum', 'LogFile');
+    my $yum_log = $cdb->get_prop_and_delete('dnf', 'LogFile');
    return $out;
 }

--- a/root/usr/share/smanager/lib/SrvMngr/Plugin/Cache.pm
+++ b/root/usr/share/smanager/lib/SrvMngr/Plugin/Cache.pm
@@ -0,0 +1,73 @@
+package SrvMngr::Plugin::Cache;
+use Mojo::Base -base;
+
+=head1 NAME
+
+Mojolicious::Plugin::Renderer::WithoutCache::Cache - Mojo::Cache that doesn't cache
+
+=head1 VERSION
+
+Version 0.04
+
+=cut
+
+our $VERSION = '0.04';
+$VERSION = eval $VERSION;
+
+=head1 SYNOPSIS
+
+You probably don't want to use this directly.
+
+    my $cache = Mojolicious::Plugin::Renderer::WithoutCache::Cache->new;
+    # this cache does nothing
+
+=head1 DESCRIPTION
+
+A cache object that's compatible to Mojo::Cache but does nothing. It does
+not save or return any values. It's always empty.
+
+=head1 METHODS
+
+=head2 get
+
+Does nothing. Returns C<undef>.
+
+=cut
+
+sub get {}
+
+=head2 set
+
+Does nothing. Returns C<$self> so chaining is possible.
+
+=cut
+
+sub set { shift; }
+
+=head2 max_keys
+
+Always returns zero. Can't be set. We don't want any keys.
+
+=cut
+
+sub max_keys { 0 }
+
+=head1 AUTHOR
+
+simbabque, C<< <simbabque at cpan.org> >>
+
+=head1 BUGS
+
+Please report any bugs or feature requests through an issue
+on github at L<https://github.com/simbabque/Mojolicious-Plugin-Renderer-WithoutCache/issues>.
+
+=head1 LICENSE
+
+Copyright (C) simbabque.
+
+This library is free software; you can redistribute it and/or modify
+it under the same terms as Perl itself.
+
+=cut
+
+1;
--- a/root/usr/share/smanager/lib/SrvMngr/Plugin/WithoutCache.pm
+++ b/root/usr/share/smanager/lib/SrvMngr/Plugin/WithoutCache.pm
@@ -0,0 +1,94 @@
+package SrvMngr::Plugin::WithoutCache;
+use Mojo::Base 'Mojolicious::Plugin';
+use SrvMngr::Plugin::Cache;
+
+=head1 NAME
+
+Mojolicious::Plugin::Renderer::WithoutCache - Disable the template cache in your Mojo app
+
+=begin html
+
+<p>
+<a href="https://travis-ci.org/simbabque/Mojolicious-Plugin-Renderer-WithoutCache"><img src="https://travis-ci.org/simbabque/Mojolicious-Plugin-Renderer-WithoutCache.svg?branch=master"></a>
+<a href='https://coveralls.io/github/simbabque/Mojolicious-Plugin-Renderer-WithoutCache?branch=master'><img src='https://coveralls.io/repos/github/simbabque/Mojolicious-Plugin-Renderer-WithoutCache/badge.svg?branch=master' alt='Coverage Status' /></a>
+</p>
+
+=end html
+
+=head1 VERSION
+
+Version 0.04
+
+=cut
+
+our $VERSION = '0.04';
+$VERSION = eval $VERSION;
+
+=head1 SYNOPSIS
+
+This plugin turns off the renderer's cache in L<Mojolicious> and L<Mojo::Lite> applications.
+
+    use Mojolicious::Lite;
+    plugin 'Renderer::WithoutCache';
+
+=head1 DESCRIPTION
+
+This does what it says on the box. It turns off caching for the L<Mojolicious::Renderer>
+or any other renderer that's inside C<$app-E<gt>renderer> by injecting a cache object that
+does not do anything. This is superior to setting the C<max_keys> of L<Mojo::Cache>
+to C<0> if you plan to do a lot of uncached requests, because L<Mojolicious::Renderer>
+will still try to cache, and every time L<Mojo::Cache> sets a value in the cache it
+looks at the C<max_keys>, and then stops.
+
+Doing nothing at all is cheaper. But not a lot really.
+
+=head1 METHODS
+
+=head2 register
+
+Register the plugin in a L<Mojolicious> application.
+
+    $plugin->register(Mojolicious->new);
+
+=cut
+
+sub register {
+    my ( $self, $app ) = @_;
+    $app->renderer->cache( SrvMngr::Plugin::Cache->new );
+}
+
+=head1 AUTHOR
+
+simbabque, C<< <simbabque at cpan.org> >>
+
+=head1 BUGS
+
+Please report any bugs or feature requests through an issue
+on github at L<https://github.com/simbabque/Mojolicious-Plugin-Renderer-WithoutCache/issues>.
+
+=head1 SUPPORT
+
+You can find documentation for this module with the perldoc command.
+
+    perldoc Mojolicious::Plugin::Renderer::WithoutCache
+
+=head2 Why would I want to turn off the cache?
+
+I don't know.
+
+=head1 ACKNOWLEDGEMENTS
+
+This plugin was inspired by Tom Hunt asking about turning the cache off
+on L<Stack Overflow|http://stackoverflow.com/q/41750243/1331451>.
+
+=head1 LICENSE
+
+Copyright (C) simbabque.
+
+This library is free software; you can redistribute it and/or modify
+it under the same terms as Perl itself.
+
+=cut
+
+1;
+
--- a/root/usr/share/smanager/themes/default/public/js/flag-by-locale.js
+++ b/root/usr/share/smanager/themes/default/public/js/flag-by-locale.js
@@ -1,63 +1,278 @@
 document.addEventListener('DOMContentLoaded', () => {
  const flagContainer = document.getElementById('flag-container');

-  // Function to get the browser's locale
-  function getBrowserLocale() {
-    return navigator.language || navigator.userLanguage;
-  }
+        async function getCountryName(countryCode) {
+            try {
+                const response = await fetch(`https://restcountries.com/v3.1/alpha/${countryCode}`);
+                if (!response.ok) throw new Error('Country not found');
+                const data = await response.json();
+                // Return the name in the native language
+                return data[0].name.common; 
+            } catch (error) {
+                console.error(error);
+                return 'Unknown Country';
+            }
+        }

-  // Function to map locale to country code
-  function getCountryCodeFromLocale(locale) {
-    const localeParts = locale.split('-');
-    return localeParts.length > 1 ? localeParts[1] : localeParts[0];
-  }
+        function getFlagEmoji(locale) {
+            // Split the locale to get the language and country code
+            const parts = locale.split('-');
+            let countryCode;

-  // Function to fetch country names from a CDN
-  async function fetchCountryNames() {
-    const response = await fetch('https://restcountries.com/v3.1/all');
-    const countries = await response.json();
-    const countryNames = {};
-    for (const country of countries) {
-      const code = country.cca2.toLowerCase(); // Country code (ISO 3166-1 alpha-2)
-      const name = country.name.common; // Common name of the country
-      countryNames[code] = name;
-    }
-    return countryNames;
-  }
+            // Handle single subtag (language only) or double subtag (language-country)
+            if (parts.length === 1) {
+                countryCode = getCountryCodeFromLanguage(parts[0]);
+            } else if (parts.length === 2) {
+                countryCode = parts[1].toLowerCase(); // Use the country code
+            }

-  // Function to create and display the flag icon
-  function displayFlagIcon(countryCode, countryName) {
-    const flagIcon = document.createElement('span');
-    flagIcon.className = `flag-icon flag-icon-${countryCode.toLowerCase()}`;
-    flagIcon.id = 'flag-icon';
-    flagIcon.title = countryName; // Set the title for the tooltip
+            // If country code is not found, set a fallback output
+            if (!countryCode) {
+                const fallback = `? ${locale.toUpperCase()}`; // Just a question mark and the full locale
+                return { flag: fallback, isUnknown: true, countryName: 'Unknown Country' };
+            }

-    // If you want a custom tooltip instead (uncomment the lines below):
-    /*
-    const tooltip = document.createElement('span');
-    tooltip.className = 'tooltip';
-    tooltip.innerText = countryName;
-    flagIcon.appendChild(tooltip);
+            // Convert the country code to a flag emoji
+            return {
+                flag: String.fromCodePoint(...[...countryCode.toUpperCase()].map(char => 0x1F1E6 + char.charCodeAt(0) - 'A'.charCodeAt(0))),
+                isUnknown: false,
+                countryCode: countryCode
+            };
+        }

-    flagIcon.addEventListener('mouseenter', () => {
-      tooltip.style.display = 'block';
-    });
+        function getCountryCodeFromLanguage(language) {
+            // Map languages to countries (this is an example, extend as needed)
+            const languageToCountryMap = {
+                  // Add more mappings as needed
+    "af": "NA",
+    "agq": "CM",
+    "ak": "GH",
+    "am": "ET",
+    "ar": "01",
+    "as": "IN",
+    "asa": "TZ",
+    "ast": "ES",
+    "az": "rl",
+    "bas": "CM",
+    "be": "BY",
+    "bem": "ZM",
+    "bez": "TZ",
+    "bg": "BG",
+    "bm": "ML",
+    "bn": "BD",
+    "bo": "CN",
+    "br": "FR",
+    "brx": "IN",
+    "bs": "rl",
+    "ca": "AD",
+    "ccp": "BD",
+    "ce": "RU",
+    "cgg": "UG",
+    "chr": "US",
+    "ckb": "IQ",
+    "cs": "CZ",
+    "cy": "GB",
+    "da": "DK",
+    "dav": "KE",
+    "de": "DE",
+    "dje": "NE",
+    "dsb": "DE",
+    "dua": "CM",
+    "dyo": "SN",
+    "dz": "BT",
+    "ebu": "KE",
+    "ee": "GH",
+    "el": "CY",
+    "en": "01",
+    "es": "ES",
+    "et": "EE",
+    "eu": "ES",
+    "ewo": "CM",
+    "fa": "AF",
+    "ff": "CM",
+    "fi": "FI",
+    "fil": "PH",
+    "fo": "FO",
+    "fr": "FR",
+    "fur": "IT",
+    "fy": "NL",
+    "ga": "IE",
+    "gd": "GB",
+    "gl": "ES",
+    "gsw": "CH",
+    "gu": "IN",
+    "guz": "KE",
+    "gv": "IM",
+    "ha": "GH",
+    "haw": "US",
+    "he": "IL",
+    "hi": "IN",
+    "hr": "HR",
+    "hsb": "DE",
+    "hu": "HU",
+    "hy": "AM",
+    "id": "ID",
+    "ig": "NG",
+    "ii": "CN",
+    "is": "IS",
+    "it": "IT",
+    "ja": "JP",
+    "jgo": "CM",
+    "jmc": "TZ",
+    "ka": "GE",
+    "kab": "DZ",
+    "kam": "KE",
+    "kde": "TZ",
+    "kea": "CV",
+    "khq": "ML",
+    "ki": "KE",
+    "kk": "KZ",
+    "kkj": "CM",
+    "kl": "GL",
+    "kln": "KE",
+    "km": "KH",
+    "kn": "IN",
+    "ko": "KP",
+    "kok": "IN",
+    "ks": "IN",
+    "ksb": "TZ",
+    "ksf": "CM",
+    "ksh": "DE",
+    "kw": "GB",
+    "ky": "KG",
+    "lag": "TZ",
+    "lb": "LU",
+    "lg": "UG",
+    "lkt": "US",
+    "ln": "AO",
+    "lo": "LA",
+    "lrc": "IQ",
+    "lt": "LT",
+    "lu": "CD",
+    "luo": "KE",
+    "Luo": "KE",
+    "luy": "KE",
+    "lv": "LV",
+    "mas": "KE",
+    "mer": "KE",
+    "mfe": "MU",
+    "mg": "MG",
+    "mgh": "MZ",
+    "mgo": "CM",
+    "mk": "MK",
+    "ml": "IN",
+    "mn": "MN",
+    "mr": "IN",
+    "ms": "BN",
+    "mt": "MT",
+    "mua": "CM",
+    "my": "MM",
+    "mzn": "IR",
+    "naq": "NA",
+    "nb": "NO",
+    "nd": "ZW",
+    "nds": "DE",
+    "ne": "IN",
+    "nl": "NL",
+    "nmg": "CM",
+    "nn": "NO",
+    "nnh": "CM",
+    "nus": "SS",
+    "nyn": "UG",
+    "om": "ET",
+    "or": "IN",
+    "os": "GE",
+    "pa": "ab",
+    "pl": "PL",
+    "ps": "AF",
+    "pt": "PT",
+    "qu": "BO",
+    "rm": "CH",
+    "rn": "BI",
+    "ro": "RO",
+    "rof": "TZ",
+    "ru": "RU",
+    "rw": "RW",
+    "rwk": "TZ",
+    "sah": "RU",
+    "saq": "KE",
+    "sbp": "TZ",
+    "se": "SE",
+    "seh": "MZ",
+    "ses": "ML",
+    "sg": "CF",
+    "shi": "tn",
+    "si": "LK",
+    "sk": "SK",
+    "sl": "SI",
+    "smn": "FI",
+    "sn": "ZW",
+    "so": "SO",
+    "sq": "AL",
+    "sr": "rl",
+    "sv": "AX",
+    "sw": "CD",
+    "ta": "IN",
+    "te": "IN",
+    "teo": "KE",
+    "tg": "TJ",
+    "th": "TH",
+    "ti": "ER",
+    "to": "TO",
+    "tr": "TR",
+    "tt": "RU",
+    "twq": "NE",
+    "tzm": "MA",
+    "ug": "CN",
+    "uk": "UA",
+    "ur": "IN",
+    "uz": "ab",
+    "vai": "tn",
+    "Vai": "tn",
+    "vi": "VN",
+    "vun": "TZ",
+    "wae": "CH",
+    "wo": "SN",
+    "xog": "UG",
+    "yav": "CM",
+    "yi": "01",
+    "yo": "BJ",
+    "yue": "ns",
+    "zgh": "MA",
+    "zh": "ns",
+    "zu": "ZA"

-    flagIcon.addEventListener('mouseleave', () => {
-      tooltip.style.display = 'none';
-    });
-    */

-    flagContainer.appendChild(flagIcon);
-  }
+            };

-  // Main logic
-  (async () => {
-    const locale = getBrowserLocale();
-    const countryCode = getCountryCodeFromLocale(locale);
-    const countryNames = await fetchCountryNames(); // Fetch country names
+            return languageToCountryMap[language] || null;
+        }

-    const countryName = countryNames[countryCode.toLowerCase()] || 'Unknown Country'; // Get the country name
-    displayFlagIcon(countryCode, countryName); // Display the flag with country name
-  })();
+        async function displayLocaleAndFlag() {
+            // Get the browser locale
+            const userLocale = navigator.language || navigator.userLanguage;
+            const { flag, isUnknown, countryCode } = getFlagEmoji(userLocale);
+
+            // Display the locale and the corresponding flag (or fallback)
+            //document.getElementById('locale').textContent = `Your Locale: ${userLocale}`;
+
+            if (isUnknown) {
+                const fallbackDiv = document.createElement('div');
+                fallbackDiv.className = 'fallback-box';
+                fallbackDiv.textContent = `? ${userLocale.toUpperCase()}`; // Only show ? and locale code inside the box
+                //document.getElementById('flag-container').textContent = "Flag: ";
+                document.getElementById('flag-container').appendChild(fallbackDiv);
+                // Tooltip for fallback
+                fallbackDiv.title = "Unknown Country"; // Tooltip for fallback
+            } else {
+                const countryName = await getCountryName(countryCode);
+                const flagSpan = document.createElement('span');
+                flagSpan.textContent = flag; // Use flag emoji
+                flagSpan.title = countryName; // Tooltip for the flag in country language
+                //document.getElementById('flag-container').textContent = "Flag: ";
+                document.getElementById('flag-container').appendChild(flagSpan);
+            }
+        }
+
+        displayLocaleAndFlag();
 });
--- a/root/usr/share/smanager/themes/default/templates/emailreceive.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/emailreceive.html.ep
@@ -1,12 +1,17 @@
 % layout 'default', title => "Sme server 2 - emailreceive";

 % content_for 'module' => begin
+
+% use constant FALSE => 0;
+% use constant TRUE  => 1;
+
 <div id='module' class='module emailreceive-panel'>

    % if ($config->{debug} == 1) {
 	<p>
 	%= dumper $c->current_route
 	%= dumper $mai_datas
+	%= dumper $c->param('SMTPAuth')
 	</p>
    % }

@@ -26,16 +31,65 @@
 	%=l 'mai_LABEL_MODE'
 	</span><span class=input>
 	% param 'FetchmailMethod' => $mai_datas->{fetchmailmethod} unless param 'FetchmailMethod';
+<!--
+	<pre>
+		%= dumper $mai_datas->{fetchmailmethod}
+		%= dumper $c->get_retrieval_opt()
+		%= param 'FetchmailMethod'
+	</pre>
+-->
 	%= select_field 'FetchmailMethod' => $c->get_retrieval_opt(), class => 'input'
 	</span></p>

-	%=l 'mai_DESC_SMTP_AUTH_CONTROL'
+	%#=l 'mai_DESC_SMTP_AUTH_CONTROL'
+	<br />
+	%= l "SMTP port (25) main purpose is to receive emails from another server, STARTTLS is always offered, but auth if offered is only if STARTTLS is also used by client."
+	<br />
+	%= l "SMTPS port (465) will require implicit SSL/TLS then authenticate to send."
+	<br />
+	%= l "SMTP Submission port (587) will require STARTTLS, then authenticate to send."
+	<br />

+	% my $smtp_mesg=l('SMTP port %u allow client to authenticate:');
 	<p><span class=label>
-	%=l 'mai_LABEL_SMTP_AUTH_CONTROL'
+		%= sprintf($smtp_mesg,$c->get_db_prop('qpsmtpd','TCPPort',25)); 
 	</span><span class=input>
-    	% param 'SMTPAuth' => $c->get_current_smtp_auth() unless param 'SMTPAuth';
-	%= select_field 'SMTPAuth' => $c->get_smtp_auth_opt(), class => 'input'
+    	% param 'SMTPAuth' => $c->get_current_smtp_auth( FALSE ) unless param 'SMTPAuth';
+<!--
+	<pre>
+		%= dumper $c->get_smtp_auth_opt()
+		%= dumper $c->get_current_smtp_auth(FALSE)
+		%= dumper $c->get_db_prop("qpsmtpd","Authentication")
+		%= param 'SMTPAuth'
+	</pre>
+-->
+		%= select_field 'SMTPAuth' => $c->get_smtp_auth_opt(), class => 'input'
+	</span></p>
+
+	% my $smtp_mesg=l('SMTPS SSL/TLS auth: port %u status:');
+	<p><span class=label>
+		%= sprintf($smtp_mesg,$c->get_db_prop('sqpsmtpd','TCPPort',465)); 
+	</span><span class=input>
+		% param 'sSMTPAuth' => $c->get_current_smtp_ssl_auth(FALSE,'s', TRUE) unless param 'sSMTPAuth';
+	
+		%= select_field 'sSMTPAuth' => $c->get_smtp_ssl_auth_opt(), class => 'input'
+	</span></p>
+
+	%my $smtp_mesg=l('Submission port %u status:');
+	<p><span class=label>
+		%= sprintf($smtp_mesg,$c->get_db_prop('uqpsmtpd','TCPPort',587)); 
+	</span><span class=input>
+    	% param 'uSMTPAuth' => $c->get_current_smtp_ssl_auth(FALSE,'u', TRUE) unless param 'uSMTPAuth';
+<!--
+	<pre>
+		%= dumper $c->get_smtp_ssl_auth_opt()
+		%= dumper $c->get_current_smtp_ssl_auth(FALSE,'s', TRUE)
+		%= dumper $c->get_current_smtp_ssl_auth(FALSE,'u', TRUE)
+		%= dumper $c->get_db_prop("uqpsmtpd","access")
+		%= param 'uSMTPAuth'
+	</pre>
+-->
+	%= select_field 'uSMTPAuth' => $c->get_smtp_ssl_auth_opt(), class => 'input'
 	</span></p>

 	<hr class="sectionbar" />
@@ -110,4 +164,4 @@
    % end    

 </div>
-%end
+%end
--- a/root/usr/share/smanager/themes/default/templates/emailsettings.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/emailsettings.html.ep
@@ -1,9 +1,13 @@
 % layout 'default', title => "Sme server 2 - emailsettings";

 % content_for 'module' => begin
+
+% use constant FALSE => 0;
+% use constant TRUE  => 1;
+
 <div id='module' class='module emailsettings-panel'>

-    % if ($config->{debug} == 1) {
+    % if ($config->{debug} == TRUE) {
 	<p>
 	%= dumper $c->current_route
 	%= dumper $mai_datas
@@ -22,19 +26,19 @@
 	<p><span class=label>
 	%=l 'mai_LABEL_POP_ACCESS_CONTROL'
 	</span><span class=data2>
-	%= $c->get_current_pop3_access( 1 )
+	%= $c->get_current_pop3_access( TRUE )
 	</span></p>

 	<p><span class=label>
 	%=l 'mai_LABEL_IMAP_ACCESS_CONTROL'
 	</span><span class=data2>
-	%= $c->get_current_imap_access( 1 )
+	%= $c->get_current_imap_access( TRUE )
 	</span></p>

 	<p><span class=label>
 	%=l 'mai_LABEL_WEBMAIL'
 	</span><span class=data2>
-	%= $c->get_current_webmail_status( 1 )
+	%= $c->get_current_webmail_status( TRUE )
 	</span></p>

    % 	my $btn = l('mai_DESC_STATE_ACCESS_BUTTON');
@@ -51,19 +55,19 @@
 	<p><span class=label>
 	%=l 'mai_LABEL_VIRUS_SCAN'
 	</span><span class=data2>
-	%= $c->get_virus_status(1)
+	%= $c->get_virus_status(TRUE)
 	</span></p>

 	<p><span class=label>
 	%=l 'mai_LABEL_SPAM_SCAN'
 	</span><span class=data2>
-	%= $c->get_spam_status(1)
+	%= $c->get_spam_status(TRUE)
 	</span></p>

 	<p><span class=label>
 	%=l 'mai_LABEL_BLOCK_EXECUTABLE_CONTENT'
 	</span><span class=data2>
-	%= $c->get_patterns_status(1)
+	%= $c->get_patterns_status(TRUE)
 	</span></p>

    % 	my $btn = l('mai_DESC_STATE_FILTERING_BUTTON');
@@ -83,12 +87,28 @@
 	%= $mai_datas->{fetchmailmethod}
 	</span></p>

+	% my $smtp_mesg=l('SMTP port %u allow client to authenticate:');
 	<p><span class=label>
-	%=l 'mai_LABEL_SMTP_AUTH_CONTROL'
+		%= sprintf($smtp_mesg,$c->get_db_prop('qpsmtpd','TCPPort',25)); 
 	</span><span class=data2>
-	%= $c->get_current_smtp_auth( 1 )
+	%= $c->get_current_smtp_auth( TRUE )
 	</span></p>

+	% my $smtp_mesg=l('SMTPS SSL/TLS auth: port %u status:');
+	<p><span class=label>
+		%= sprintf($smtp_mesg,$c->get_db_prop('sqpsmtpd','TCPPort',465)); 
+	</span><span class=data2>
+	%= $c->get_current_smtp_ssl_auth( TRUE, 's', FALSE )
+	</span></p>
+
+	%my $smtp_mesg=l 'Submission port %u status:';
+	<p><span class=label>
+		%= sprintf($smtp_mesg,$c->get_db_prop('uqpsmtpd','TCPPort',587)); 
+	</span><span class=data2>
+	%= $c->get_current_smtp_ssl_auth( TRUE,'u', FALSE )
+	</span></p>
+	<br />
+
    % 	my $btn = l('mai_DESC_STATE_RECEPTION_BUTTON');
    <div class='center'>
 	%= submit_button "$btn", class => 'action'
@@ -103,7 +123,7 @@
 	<p><span class=label>
 	%=l 'mai_LABEL_UNKNOWN'
 	</span><span class=data2>
-	%= $c->get_emailunknownuser_status( 1 )
+	%= $c->get_emailunknownuser_status( TRUE )
 	</span></p>

 	<p><span class=label>
@@ -127,4 +147,4 @@
    % end    

 </div>
-%end
+%end
--- a/root/usr/share/smanager/themes/default/templates/layouts/default.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/layouts/default.html.ep
@@ -35,6 +35,19 @@

 	<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/flag-icon-css/3.5.0/css/flag-icon.min.css">
 	%= stylesheet '/css/sme-jquery-overrides.css'
+	
+	<style>
+	#busy-indicator {
+		display: none;
+		margin-top: 10px;
+		font-weight: bold;
+		color: red;
+	}
+	.busy {
+		cursor: wait; /* Change the cursor to a 'wait' cursor */
+	}
+	</style>
+

 </head>

@@ -94,6 +107,22 @@
    % }

 %= javascript '/js/sme-dataTable-setup.js'
+
+	<script>
+		$(document).ready(function() {
+			// Handle form submission for any form
+			$('form').on('submit', function(event) {
+				// Disable the submit button
+				$(this).find('button[type="submit"], input[type="submit"]').prop('disabled', true);
+				// Show the busy indicator
+//				$('#busy-indicator').show();
+				
+				// Change the cursor to "wait"
+				$('body').addClass('busy');
+			});
+		});
+	</script>
+
  
 </body>
 </html>
--- a/root/usr/share/smanager/themes/default/templates/partials/_footer.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/partials/_footer.html.ep
@@ -3,7 +3,7 @@
 <a href="https://mojolicious.org" target="_blank"><img src="images/sme-mojo-logo-white.png" style="position:relative;"></a>
 <font class="sme-copyright">
 %	if ( $c->is_logged_in ) {
-	SME Server <%= session 'releaseVersion' %> - Manager <%= $c->app->VERSION %>
+	SME Server <%= session 'releaseVersion' %>-<%= $c->app->VERSION %> Manager II
 % }
 <br>Copyright 1999-2006 Mitel Corporation<br>
 %= session 'copyRight'
--- a/root/usr/share/smanager/themes/default/templates/partials/_header.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/partials/_header.html.ep
@@ -1,30 +1,128 @@
+<style>
+#h2l1 {
+    display: flex;                  /* Use flexbox layout */
+    justify-content: space-between; /* Space between child elements */
+    align-items: center;           /* Center items vertically */
+}
+
+#h2e11 {
+    flex: 1;                       /* Allow the first div to take available space on the left */
+}
+
+#h2e12 { 
+    display: flex;                 /* Make this div a flex container */
+    align-items: center;           /* Vertically center content in this div */
+    margin-left: 20px;            /* Add margin to the left of this div */
+}
+
+#flag-container {
+    display: flex;                 /* Make this div a flex container */
+    align-items: center;           /* Vertically center content in this div */
+    margin-left: 20px;             /* Add margin to the left of the flag container */
+    padding-right: 20px;           /* Add padding to the right side of the flag container */
+}
+
+.flag-icon {
+    width: 43px;
+    font-size: 20px;
+}
+
+#legacy-button button {
+    background-color: #98d36e; /* Button background color */
+    font-weight: lighter;      /* Lighter text for the button */
+    color: #063;               /* Button text color */
+    padding: 5px 10px;         /* Padding for the button */
+    border: none;              /* Remove default button border */
+    border-radius: 4px;        /* Rounded corners for button */
+    cursor: pointer;           /* Change cursor on hover */
+}
+
+#legacy-button button:hover {
+    background-color: #82c961; /* Change color on hover */
+}
+
+.infobar {
+    display: flex;                  /* Use flexbox for alignment */
+    justify-content: space-between; /* Space between child elements */
+    align-items: center;            /* Center items vertically */
+    padding: 10px;                  /* Adjust padding as desired */
+}
+
+#h2e21 {
+    flex: 1;                        /* Allow the first div to take available space on the left */
+}
+
+#h2e22 {
+    display: flex;                  /* Make this div a flex container */
+    justify-content: center;        /* Center the help button */
+    align-items: center;            /* Center vertically */
+    flex: none;                    /* Prevent this div from growing */
+    position: relative;             /* Relative position for centering */
+    width: 100px;                  /* Set a width for the help button container */
+}
+
+#h2e23 {
+    margin-left: auto;              /* Push the third div to the right */
+}
+
+.login-button {
+    background-color: #98d36e;     /* Button background color */
+    font-weight: bold;              /* Bold text */
+    xxcolor: #ffffff;                 /* Button text color */
+    padding: 8px 12px;              /* Adjust padding for button height */
+    border: none;                   /* Remove default border */
+    border-radius: 4px;             /* Rounded corners */
+    cursor: pointer;                /* Change cursor on hover */
+}
+
+.login-button:hover {
+    background-color: #82c961;      /* Change color on hover */
+}
+
+#help-button {
+    text-decoration: none;          /* Remove underline from link */
+    font-size: 20px;                /* Adjust font size as needed */
+    padding: 8px 12px;              /* Add padding to the help link */
+    background-color: #98d36e;      /* Background for visibility */
+    border-radius: 4px;             /* Rounded corners */
+    color: #000;                    /* Button text color */
+}
+
+#help-button:hover {
+    background-color: #82c961;      /* Change background on hover */
+}
+</style>
+
 <div id="header2" class="hd2">
    <div id="h2l1"> 
 		<div id="h2e11">
 			<a target='_blank' href="http://www.koozali.org"><img src="images/smeserver_logo.jpg" height="40" alt="SME Server"></a>
-		</div>     
-        <div id="h2e12" style="float:right;">
-			<br><a href="/server-manager" target='_blank'><button style="background-color:#98d36e;font-weight:bold;color:#063;">Legacy SM</button></a>
+		</div> 
+
+		<div id="h2e22">
+			<a id="help-button" target="_parent" href="manual"><button> ? </button></a>
+		</div>
+    
+        <div id="h2e12">
+			<a id="legacy-button" href="/server-manager" target='_blank'><button>Legacy SM</button></a>
        </div>
+		<div id="h2e23">
+			% if ( not defined $c->session->{username} ) {
+				<a target="_parent" href="login"><button class="login-button">Login</button></a>
+			% } else {
+				<a target="_parent" href="logout"><button class="login-button"><%= $c->session->{username} %> Logout</button></a>
+			% }
+		</div>
 		<div id="flag-container">
 			<!-- The flag icon will be inserted here -->
 		</div>
    </div>
-    <div id="h2l2" class="infobar"> 
+	<div id="h2l2" class="infobar"> 
 		<div id="h2e21">
 			<b>
-			<%= session 'SystemName' %>@<%= session 'DomainName' %></b> 
-			</div>
-				<div id="h2e22">
-				  <a target="_parent" href="manual">&nbsp;&nbsp;<b> ? </b>&nbsp;&nbsp;</a>&nbsp;
-			</div>
-			<div id="h2e23">
-		%    if ( not defined $c->session->{username} ) {
-				  <a target="_parent" href="login"><b>Login</b></a>&nbsp;
-		%    } else {
-				  <a target="_parent" href="logout"><b><%= $c->session->{username} %> Logout</b></a>&nbsp;
-		%    }
-			</div>
+				<%= session 'SystemName' %>@<%= session 'DomainName' %></b> 
 		</div>
+		
+		
 	</div>
 </div>
--- a/root/usr/share/smanager/themes/default/templates/partials/_usr_list.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/partials/_usr_list.html.ep
@@ -76,11 +76,17 @@
    % 			$actionRemove = "<a href='useraccountsd?CsrfDef=TOKEN&trt=DEL&user=" . $username . "'>" . "<button class='sme-remove-button' title=".l("REMOVE").">".l("REMOVE")."</button></a>"; 
    %		}
    %	    }
+    %		
+    %		my $thisdomain = session 'SystemName';
+    %		$thisdomain .= ".".session 'DomainName';
+    %#		my $thisdomain = "localhost";
+
    	    <td class='sme-border' style="min-width:35em">
 				<%= $c->render_to_string(inline => $actionModify) %>
 				<%= $c->render_to_string(inline => $actionResetPw) %>
 				<%= $c->render_to_string(inline => $actionLock) %>
 				<%= $c->render_to_string(inline => $actionRemove) %>
+				<a href="<%= "roundcubepanel/?url=https://".$thisdomain."/" %>roundcube?_user=<%= $username %>"><button class="sme-email-button" title="<%= l('EMAIL') %>"><%= l('EMAIL') %></button></a>
    	    </td>
    	</tr>
    %    }
--- a/root/usr/share/smanager/themes/default/templates/roundcube.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/roundcube.html.ep
@@ -0,0 +1,39 @@
+% layout 'default', title => "Sme server 2 -  roundcube";
+
+% content_for 'module' => begin
+
+
+<div id='roundcube' class='roundcube roundcube-panel'>
+    % if ($config->{debug} == 1) {
+		<p>
+			%= dumper $c->current_route
+		</p>
+    % }
+    % if ( stash 'error' ) {
+    	<br><div class=sme-error>
+			%= $c->render_to_string(inline => stash 'error') 
+		</div>
+    %}
+    <h1> roundcube - <%=$title %></h1><br>
+    <p>If the roundcube panel does not appear after logging in, then please check your password.</p><br />
+
+    % my $thisdomain = session 'SystemName';
+    % $thisdomain .= ".".session 'DomainName';
+    % my $url = $c->stash('modul');
+    % my $username = 'admin';
+    % if ($url =~ /[?&]_user=([^&]+)/) {
+	%	$username = $1;
+	%}
+	
+	<a href="<%= "https://".$thisdomain."/" %>roundcube?_user=<%= $username %>"><button class="sme-fullwindow1-button" width=20em title="<%= l('Full Window') %>"><%= l('Full Window') %></button></a>
+
+    % my $height = $c->stash('height') | '600px';
+    % if ($height !~ /px$/) { $height = $height.'px';}
+    % if ($url eq "") {
+	%	$url = "https://".$thisdomain."/roundcube";
+	%}
+	<object id="roundcube" class="roundcube" data="<%=$url %>" style="width:99%;height:<%= $height %>;" title="<%= $c->stash('title') %>"  type="text/html" ><%= $c->stash('title') %> not found</object>
+</div>
+
+
+%end
--- a/root/usr/share/smanager/themes/default/templates/yumconfig.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/yumconfig.html.ep
@@ -79,9 +79,9 @@

    	%=  hidden_field 'trt' => 'CONF'
 	<br>
-    <div class='center'>
+    <!--<div class='center'>-->
 	%= submit_button $c->l('SAVE'), class => 'action'
-    </div>
+    <!--</div>-->

    % end

--- a/root/usr/share/smanager/themes/default/templates/yuminstall.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/yuminstall.html.ep
@@ -47,9 +47,9 @@

    	%=  hidden_field 'trt' => 'INST'
 	<br><br>
-    <div class='center'>
+    <!-- <div class='center'>-->
 	%= submit_button $c->l('yum_INSTALL_SOFTWARE'), class => 'action'
-    </div>
+    <!--</div>-->

    % end

--- a/root/usr/share/smanager/themes/default/templates/yumpostupg.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/yumpostupg.html.ep
@@ -34,9 +34,9 @@
    	%=  hidden_field 'trt' => 'PSTU'
    	%=  hidden_field 'reconf' => $yum_datas->{reconf}
 	<br>
-    <div class='center'>
+    <!-- <div class='center'>-->
 	%= submit_button "$btn", class => 'action'
-    </div>
+    <!--</div>-->

    % end

--- a/root/usr/share/smanager/themes/default/templates/yumremove.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/yumremove.html.ep
@@ -46,9 +46,9 @@

    	%=  hidden_field 'trt' => 'REMO'
 	<br>
-    <div class='center'>
+    <!--<div class='center'>-->
 	%= submit_button $c->l('REMOVE'), class => 'action'
-    </div>
+    <!--</div>-->

    % end

--- a/root/usr/share/smanager/themes/default/templates/yumupdate.html.ep
+++ b/root/usr/share/smanager/themes/default/templates/yumupdate.html.ep
@@ -33,9 +33,9 @@

    	%=  hidden_field 'trt' => 'UPDT'
 	<br>
-    <div class='center'>
+    <!--<div class='center'>-->
 	%= submit_button $c->l('yum_INSTALL_UPDATES'), class => 'action'
-    </div>
+    <!--</div>-->

    % end

--- a/smeserver-manager.spec
+++ b/smeserver-manager.spec
@@ -2,7 +2,7 @@ Summary: Sme server  navigation module : manager 2
 %define name smeserver-manager
 Name: %{name}
 %define version 11.0.0
-%define release 11
+%define release 29
 Version: %{version}
 Release: %{release}%{?dist}
 License: GPL
@@ -49,6 +49,11 @@ This RPM contributes the navigation bars for the smeserver-manager. New Mojolici
 %setup

 %build
+
+#extract the release number and drop it in to the version for SM2 footer.
+sed -i "s/our \$VERSION = '[^']*'/our \$VERSION = '%{release}'/g" root/usr/share/smanager/lib/SrvMngr.pm
+
+
 perl createlinks

 # Force creation of potentially empty directories
@@ -108,6 +113,65 @@ true
 %defattr(-,root,root)

 %changelog
+* Tue Nov 26 2024 Brian Read <brianr@koozali.org> 11.0.0-29.sme
+- Fix remoteaccess panel, reformat pm file and bring success panel into line with other similar panels [SME: 12747]
+
+* Fri Oct 18 2024 Brian Read <brianr@koozali.org> 11.0.0-28.sme
+- Add in emailsettings for port 25,465 and 587  [SME: 12750]
+- Comment out change to localhost for roundcube in _user_list email icon setting [SME: 12751]
+
+* Sun Oct 06 2024 Brian Read <brianr@koozali.org> 11.0.0-27.sme
+- Add in change to _user_list.html.ep for access to roundcube email from useraccounts [SME: 12751]
+
+* Fri Oct 04 2024 Brian Read <brianr@koozali.org> 11.0.0-26.sme
+- Add in email link to roundcube from user accounts [SME: 12751]
+
+* Wed Oct 02 2024 Brian Read <brianr@koozali.org> 11.0.0-25.sme
+- Add in cursor change when save/submit pressed to indicate processing [SME: 12748]
+
+* Wed Oct 02 2024 Brian Read <brianr@koozali.org> 11.0.0-24.sme
+- Messed up build - finger trouble [SME: 12753]
+
+* Wed Oct 02 2024 Brian Read <brianr@koozali.org> 11.0.0-23.sme
+- Add release number to footer  [SME: 12753]
+
+* Tue Sep 24 2024 Jean-Philippe Pialasse <jpp@koozali.org> 11.0.0-22.sme
+- fix typos, and tidy tabs [SME: 12744]
+
+* Mon Sep 23 2024 Brian Read <brianr@koozali.org> 11.0.0-21.sme
+- Remove both option for webmail [SME: 12744]
+- Add in re-open DB for portforwarding and email settings.
+
+* Mon Sep 23 2024 Jean-Philippe Pialasse <jpp@koozali.org> 11.0.0-20.sme
+- webmail switch panel to use roundcube [SME: 12742]
+- prevent browser from caching [SME: 12695]
+
+* Thu Sep 05 2024 Brian Read <brianr@koozali.org> 11.0.0-19.sme
+- Add in mojo plugin WithoutCache [SME: 12695]
+
+* Sun Aug 25 2024 Brian Read <brianr@koozali.org> 11.0.0-18.sme
+- Move flag to emojii from downloaded jpg. Fix singleton locale issue[SME: 12706]
+
+* Thu Aug 22 2024 Brian Read <brianr@koozali.org> 11.0.0-17.sme
+- Left Align Software Install panels Submit button [SME: 12727]
+
+* Wed Aug 21 2024 Brian Read <brianr@koozali.org> 11.0.0-16.sme
+- Typo uc DNF changed to lc dnf in Yum.pm [SME: 127245]
+- Monitor dnf running using dnf status file 
+
+* Wed Aug 21 2024 Brian Read <brianr@koozali.org> 11.0.0-15.sme
+- Migrate SM2 Software installer panel from use of yum to dnf [SME: 12718]
+
+* Sun Jul 28 2024 Brian Read <brianr@koozali.org> 11.0.0-14.sme
+- Version skipped due to operator error! [SME: <none> ]
+
+* Sun Jul 28 2024 Brian Read <brianr@koozali.org> 11.0.0-13.sme
+- Fix sysles.css template - overwrote it by mistake [SME: 12706]
+- Also re-organised login and Legacy SM menus and help on top
+
+* Sun Jul 28 2024 Brian Read <brianr@koozali.org> 11.0.0-12.sme
+- correct positio of flag-icon [SME: 12706]
+
 * Sat Jul 27 2024 Brian Read <brianr@koozali.org> 11.0.0-11.sme
 - Add in flag icon indication of locale [SME: 12706]
Author	SHA1	Message	Date
Brian Read	2b83be6d70	Fix 1267 in remoteaccess panel	2024-11-26 16:38:31 +00:00
Brian Read	6c1b6ed1f4	Add *.bak to .gitignore	2024-11-12 19:20:21 +00:00
Brian Read	3fa8ab5eda	Update README with specific Bugzilla links	2024-10-27 14:23:06 +00:00
Brian Read	55465e3081	Update readme bugzilla link to show all outstanding bugs	2024-10-27 12:12:21 +00:00
Brian Read	e5b9a012d9	* Fri Oct 18 2024 Brian Read <brianr@koozali.org> 11.0.0-28.sme - Add in emailsettings for port 25,465 and 587 [SME: 12750] - Comment out change to localhost for roundcube in _user_list email icon setting [SME: 12751]	2024-10-18 11:46:27 +01:00
Brian Read	fbdf3170ec	Add in _user_list.html.ep change	2024-10-06 09:48:42 +01:00
Brian Read	87d1d072c0	* Fri Oct 04 2024 Brian Read <brianr@koozali.org> 11.0.0-26.sme - Add in email link to roundcube from user accounts [SME: 12751]	2024-10-04 12:34:34 +01:00
Brian Read	d49db26f26	Add in email link to roundcube from user accounts	2024-10-04 12:14:56 +01:00
Brian Read	c4f9d67abc	First shot at Email icon in action col for user accounts	2024-10-02 16:42:58 +01:00
Brian Read	fe62bd3e39	Add curosr change when save or submit pressed	2024-10-02 14:13:47 +01:00
Brian Read	df6d21dbc9	Up release to accomodate messed up build	2024-10-02 09:56:24 +01:00
Brian Read	9c9592f861	Add release number to footer for SM2	2024-10-02 09:12:38 +01:00
Jean-Philippe Pialasse	4d2097d2da	* Tue Sep 24 2024 Jean-Philippe Pialasse <jpp@koozali.org> 11.0.0-22.sme - fix typos, and tidy tabs [SME: 12744]	2024-09-24 22:06:09 -04:00
Brian Read	44a9ecc0e1	Remove both option for webmail, add in DB re-open in Emailsetting and Portforwarding panels	2024-09-24 17:37:52 +01:00
Jean-Philippe Pialasse	785ebcfaaf	* Mon Sep 23 2024 Jean-Philippe Pialasse <jpp@koozali.org> 11.0.0-20.sme - webmail switch panel to use roundcube [SME: 12742] - prevent browser from caching [SME: 12695]	2024-09-23 10:07:08 -04:00
Brian Read	127ea74a8b	Add in WithoutCache plugin	2024-09-05 11:57:23 +01:00
Brian Read	b9f6392c1d	Update flag to use emojii and fix singleton locale	2024-08-25 11:34:57 +01:00
Brian Read	659f060eb6	Left align submit in Software Install subservient panels	2024-08-22 15:41:04 +01:00
Brian Read	1087a8a5a2	Software Installer panel - move dnf monitoring to /var/cache/dnf.status	2024-08-22 12:17:32 +01:00
Brian Read	6a5a756438	uc DNF to lc dnf in Yum.pm	2024-08-21 16:06:16 +01:00
Brian Read	91ca26de27	Migrate panel for software installer from yum to dnf	2024-08-21 12:39:46 +01:00
Brian Read	8b93232bbe	make small changes to the readme	2024-08-16 15:42:40 +02:00
Brian Read	ed1c3e13b1	* Sun Jul 28 2024 Brian Read <brianr@koozali.org> 11.0.0-14.sme - fix [SME: ]	2024-07-28 17:15:10 +01:00
Brian Read	095a0a1499	* Sun Jul 28 2024 Brian Read <brianr@koozali.org> 11.0.0-13.sme - Fix sysles.css template - overwrote it by mistake [SME: 12706] - Also re-organised login and Legacy SM menus and help on top	2024-07-28 17:14:14 +01:00
Brian Read	d16ea6a847	Typo in styles.css template	2024-07-28 16:28:45 +01:00
Brian Read	e70cc67430	* Sun Jul 28 2024 Brian Read <brianr@koozali.org> 11.0.0-12.sme - correct positio of flag-icon [SME: 12706]	2024-07-28 15:50:26 +01:00
Brian Read	b097acafab	yet more adjustment to header button spacing	2024-07-28 15:46:08 +01:00
Brian Read	5d7655a709	and more adjustment to header	2024-07-28 14:19:54 +01:00
Brian Read	a58df95aa9	More position and format for flag-icon	2024-07-28 14:04:49 +01:00
Brian Read	251b454470	Get Flag icon in correct place	2024-07-28 12:13:03 +01:00