* Tue Nov 04 2025 Brian Read <brianr@koozali.org> 11.0.0-129.sme

- Useraccounts: Clean up forward email sub and make sure blank is errored  [SME: 13056]

root/usr/share/smanager/lib/SrvMngr/Controller/Useraccounts.pm

@@ -179,7 +179,7 @@ sub do_update {
         $res = $c->pseudonym_clash($first);
         $result .= $res unless $res eq 'OK';
 
-        if ($mail) {
+        if (defined $mail) {
             $res = $c->emailforward($mail);
             $result .= $res unless $res eq 'OK';
         }
@@ -217,7 +217,7 @@ sub do_update {
         $res = $c->pseudonym_clash($first);
         $result .= $res unless $res eq 'OK';
 
-        if ($mail) {
+        if (defined $mail) {
             $res = $c->emailforward($mail);
             $result .= $res unless $res eq 'OK';
         }
@@ -554,27 +554,31 @@ sub pseudonym_clash {
 
 sub emailforward {
     my ($c, $data) = @_;
-    my $response = $c->email_simple($data);
+    #$c->app->log->info("emailformward called with $data!");
 
-    if ($response eq "OK") {
-        return "OK";
-    } elsif ($data eq "") {
+    # Trim whitespace from $data
+    $data =~ s/^\s+|\s+$//g if defined $data;
 
-        # Blank is ok, only if we're not forwarding, which means that the
-        # EmailForward param must be set to 'local'.
+    # Check simple email validation first
+    return "OK" if $c->email_simple($data) eq "OK";
+
+    # If trimmed data is empty
+    if ($data eq "") {
         my $email_forward = $c->param('EmailForward') || '';
         $email_forward =~ s/^\s+|\s+$//g;
         return 'OK' if $email_forward eq 'local';
         return $c->l('usr_CANNOT_CONTAIN_WHITESPACE');
-    } else {
-        return $c->l('usr_CANNOT_CONTAIN_WHITESPACE')
-            if ($data =~ /\s+/);
+    }
 
-        # Permit a local address.
-        return "OK" if $data =~ /^[a-zA-Z][a-zA-Z0-9\._\-]*$/;
-        return $c->l('usr_UNACCEPTABLE_CHARS');
-    } ## end else [ if ($response eq "OK")]
-} ## end sub emailforward
+    # Reject if $data contains any whitespace inside
+    return $c->l('usr_CANNOT_CONTAIN_WHITESPACE') if $data =~ /\s/;
+
+    # Allow local address pattern
+    return "OK" if $data =~ /^[a-zA-Z][a-zA-Z0-9._-]*$/;
+
+    # Otherwise reject for unacceptable chars
+    return $c->l('usr_UNACCEPTABLE_CHARS');
+}
 
 sub get_groups {
     my ($c) = shift;

root/usr/share/smanager/themes/default/public/css/new-sme-main.css

@@ -518,4 +518,9 @@ div.roundcube #roundcube{
   /* Center aligned */
   margin-left: auto!important;
   margin-right: auto;
+}
+
+table.incolumn {
+	margin:auto;
+	color:red;
 }

root/usr/share/smanager/themes/default/templates/partials/_grp_list.html.ep

@@ -35,13 +35,13 @@
 
         % foreach my $group (@$groups)
         % {
+		  % my $csrf_token = "TOKEN"; # CSRF token for security
+		  % my $group_name = $group->key; # group name extracted from the data structure
           <tr>
             %= t td => ( class => 'sme-border' ) => $group->key
             %= t td => ( class => 'sme-border' ) => $group->prop('Description')
             <td class='sme-border' style="min-width:15em">
               % my $modify_text = l('MODIFY'); # Localized text
-              % my $csrf_token = "TOKEN"; # CSRF token for security
-              % my $group_name = $group->key; # group name extracted from the data structure
               % my $actionModify = qq{
                 % <a href="groups2?CsrfDef=$csrf_token&trt=UPD&group=$group_name"
                 % class="sme-modify-button unset ui-button ui-corner-all ui-widget ui-button-icon-only"
@@ -52,8 +52,6 @@
                 % </a>
             % };
           % my $remove_text = l('REMOVE'); # Localized text
-          % my $csrf_token = "TOKEN"; # CSRF token for security
-          % my $group_name = $group->key; # group name extracted from the data structure
           % my $actionRemove = qq{
             % <a href="groups2?CsrfDef=$csrf_token&trt=DEL&group=$group_name"
             % class="sme-remove-button unset ui-button ui-corner-all ui-widget ui-button-icon-only"

root/usr/share/smanager/themes/default/templates/partials/_usr_upd.html.ep

@@ -131,7 +131,7 @@
         %= l 'usr_GROUP_MEMBERSHIPS'
       </span>
       <span class=data>
-        <table class="sme-border "><thead>
+        <table class="sme-border incolumn"><thead>
             <tr><th class='sme-border'>
                 %= l 'usr_MEMBER'
               </th><th class='sme-border'>
@@ -182,4 +182,4 @@
 
   % end
 
-</div>
+</div>

root/usr/share/smanager/themes/default/templates/portforwarding.html.ep

@@ -5,11 +5,8 @@
 
     % if (config->{debug} == 1) {
       <p>
-        %= dumper "<pf>" . $c->current_route
-          %= dumper $c->stash("ret")
-          %= dumper $c->stash("portforwarding")
-          % my $ref = $pf_datas->{portforwarding};
-          %= dumper $ref->{TCP}->[0] . "</pf>"
+        %= dumper $c->current_route
+        %= dumper $pf_datas
       </p>
     % }
 
@@ -29,4 +26,4 @@
   % }
 
 </div>
-% end
+% end

smeserver-manager.spec

@@ -2,7 +2,7 @@ Summary: Sme Server Configuration : Manager 2
 %define name smeserver-manager
 Name: %{name}
 %define version 11.0.0
-%define release 125
+%define release 129
 Version: %{version}
 Release: %{release}%{?dist}
 License: GPL
@@ -147,6 +147,18 @@ true
 %defattr(-,root,root)
 
 %changelog
+* Tue Nov 04 2025 Brian Read <brianr@koozali.org> 11.0.0-129.sme
+- Useraccounts: Clean up forward email sub and make sure blank is errored  [SME: 13056]
+
+* Tue Nov 04 2025 Brian Read <brianr@koozali.org> 11.0.0-128.sme
+- Move group table to under others in User accounts setup panel [SME: 13068]
+
+* Tue Nov 04 2025 Brian Read <brianr@koozali.org> 11.0.0-127.sme
+- Group panel: Move same var declations to outside innner scope [SME: 13073]
+
+* Tue Nov 04 2025 Brian Read <brianr@koozali.org> 11.0.0-126.sme
+- Remove debugging dump in portforwarding which crashes if no data  [SME: 13243]
+
 * Mon Nov 03 2025 Brian Read <brianr@koozali.org> 11.0.0-125.sme
 - Arrange that Macaddress, InternalIP and comment cleared out when host entry switched to self [SME: 13207]